Attachment 127192 Details for Bug 98195 – test-privserver: avoid -Wformat-security

[patch] test-privserver: avoid -Wformat-security

0008-test-privserver-avoid-Wformat-security.patch (text/plain), 1022 bytes, created by Simon McVittie on 2016-10-10 16:53:50 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Simon McVittie

Created: 2016-10-10 16:53:50 UTC

Size: 1022 bytes

patch

obsolete

>From 70027c94ff03b9d227d01eb5818b390a8bec952a Mon Sep 17 00:00:00 2001
>From: Simon McVittie <simon.mcvittie@collabora.co.uk>
>Date: Fri, 7 Oct 2016 19:44:47 +0100
>Subject: [PATCH 08/13] test-privserver: avoid -Wformat-security
>
>This is not a security vulnerability because it's test code that
>should never be compiled in production.
>
>Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
>---
> test/name-test/test-privserver.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/test/name-test/test-privserver.c b/test/name-test/test-privserver.c
>index 367c809..8bdd4f7 100644
>--- a/test/name-test/test-privserver.c
>+++ b/test/name-test/test-privserver.c
>@@ -95,7 +95,7 @@ main (int argc, char *argv[])
>   server = dbus_server_listen ("unix:tmpdir=/tmp", &error);
> #endif
>   if (!server)
>-    die (error.message);
>+    die ("%s", error.message);
>   testdata->private_addr = dbus_server_get_address (server);
>   fprintf (stderr, "test server listening on %s\n", testdata->private_addr);
> 
>-- 
>2.9.3
>

Actions: View | Splinter Review

Attachments on bug 98195: 127185 | 127186 | 127187 | 127188 | 127189 | 127190 | 127191 | 127192 | 127193 | 127194 | 127195 | 127196 | 127197

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.