Attachment 127214 Details for Bug 98206 – [PATCH] build: limit the available glib functionality to the version we support

[patch] [PATCH] build: limit the available glib functionality to the version we support

0001-build-limit-the-available-glib-functionality-to-the-.patch (text/plain), 1.76 KB, created by Lubomir Rintel on 2016-10-11 14:49:24 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Lubomir Rintel

Created: 2016-10-11 14:49:24 UTC

Size: 1.76 KB

patch

obsolete

>From 0475d7a93b2c4ac67199100d13fb8cb3f5bbf8cc Mon Sep 17 00:00:00 2001
>From: Lubomir Rintel <lkundrak@v3.sk>
>Date: Tue, 11 Oct 2016 16:41:52 +0200
>Subject: [PATCH] build: limit the available glib functionality to the version
> we support
>
>Otherwise we can accidentally use something that we ought not. Also,
>there's deprecation warnings for stuff that's not deprecated in the
>version we support yet:
>
>  mm-modem-simple.c: In function 'mm_modem_simple_connect_finish':
>  mm-modem-simple.c:117:5: warning: 'g_simple_async_result_propagate_error' is deprecated [-Wdeprecated-declarations]
>       if (g_simple_async_result_propagate_error (G_SIMPLE_ASYNC_RESULT (res), error))
>       ^~
>---
> configure.ac | 3 +++
> 1 file changed, 3 insertions(+)
>
>diff --git a/configure.ac b/configure.ac
>index c74d015..51f37d1 100644
>--- a/configure.ac
>+++ b/configure.ac
>@@ -102,6 +102,7 @@ PKG_CHECK_MODULES(MM,
>                   gobject-2.0
>                   gio-2.0
>                   gio-unix-2.0)
>+MM_FLAGS="$MM_CFLAGS -DGLIB_VERSION_MIN_REQUIRED=GLIB_VERSION_2_36 -DGLIB_VERSION_MAX_ALLOWED=GLIB_VERSION_2_36"
> AC_SUBST(MM_CFLAGS)
> AC_SUBST(MM_LIBS)
> 
>@@ -110,6 +111,7 @@ PKG_CHECK_MODULES(LIBMM_GLIB,
>                   gobject-2.0
>                   gio-2.0
>                   gio-unix-2.0)
>+LIBMM_GLIB_CFLAGS="$LIBMM_GLIB_CFLAGS -DGLIB_VERSION_MIN_REQUIRED=GLIB_VERSION_2_36 -DGLIB_VERSION_MAX_ALLOWED=GLIB_VERSION_2_36"
> AC_SUBST(LIBMM_GLIB_CFLAGS)
> AC_SUBST(LIBMM_GLIB_LIBS)
> 
>@@ -117,6 +119,7 @@ PKG_CHECK_MODULES(MMCLI,
>                   glib-2.0 >= $GLIB_MIN_VERSION
>                   gobject-2.0
>                   gio-2.0)
>+MMCLI_CFLAGS="$MMCLI_CFLAGS -DGLIB_VERSION_MIN_REQUIRED=GLIB_VERSION_2_36 -DGLIB_VERSION_MAX_ALLOWED=GLIB_VERSION_2_36"
> AC_SUBST(MMCLI_CFLAGS)
> AC_SUBST(MMCLI_LIBS)
> 
>-- 
>2.7.4
>

Actions: View | Splinter Review

Attachments on bug 98206: 127214

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.