Attachment 127236 Details for Bug 98174 – second patch

[patch] second patch

0001-debug-mutex-failure-again.patch (text/plain), 1019 bytes, created by Tanu Kaskinen on 2016-10-12 11:35:00 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tanu Kaskinen

Created: 2016-10-12 11:35:00 UTC

Size: 1019 bytes

patch

obsolete

>From 45a376ebac98312f210a99deb2128e8169ad7bbc Mon Sep 17 00:00:00 2001
>From: Tanu Kaskinen <tanuk@iki.fi>
>Date: Wed, 12 Oct 2016 14:28:56 +0300
>Subject: [PATCH] debug mutex failure again
>
>---
> src/pulsecore/mutex-posix.c | 10 +++++++++-
> 1 file changed, 9 insertions(+), 1 deletion(-)
>
>diff --git a/src/pulsecore/mutex-posix.c b/src/pulsecore/mutex-posix.c
>index ad29651..229afaa 100644
>--- a/src/pulsecore/mutex-posix.c
>+++ b/src/pulsecore/mutex-posix.c
>@@ -25,6 +25,8 @@
> #include <errno.h>
> 
> #include <pulse/xmalloc.h>
>+
>+#include <pulsecore/core-error.h>
> #include <pulsecore/macro.h>
> 
> #include "mutex.h"
>@@ -89,9 +91,15 @@ void pa_mutex_free(pa_mutex *m) {
> }
> 
> void pa_mutex_lock(pa_mutex *m) {
>+    int r;
>+
>     pa_assert(m);
> 
>-    pa_assert_se(pthread_mutex_lock(&m->mutex) == 0);
>+    r = pthread_mutex_lock(&m->mutex);
>+    if (r != 0) {
>+        pa_log("pthread_mutex_lock() failed: %s", pa_cstrerror(r));
>+        pa_assert_not_reached();
>+    }
> }
> 
> bool pa_mutex_try_lock(pa_mutex *m) {
>-- 
>2.9.3
>

Actions: View | Splinter Review

Attachments on bug 98174: 127210 | 127236 | 127310

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.