Attachment 127246 Details for Bug 98169 – Betetr version of the sensor_cleanup patch

[patch] Betetr version of the sensor_cleanup patch

sensor_cleanupv2.patch (text/plain), 1.27 KB, created by Steven Toth on 2016-10-12 14:50:13 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Steven Toth

Created: 2016-10-12 14:50:13 UTC

Size: 1.27 KB

patch

obsolete

>diff --git a/src/gallium/auxiliary/hud/hud_sensors_temp.c b/src/gallium/auxiliary/hud/hud_sensors_temp.c
>index e41b847..765d08f 100644
>--- a/src/gallium/auxiliary/hud/hud_sensors_temp.c
>+++ b/src/gallium/auxiliary/hud/hud_sensors_temp.c
>@@ -68,6 +68,7 @@ struct sensors_temp_info
>    sensors_chip_name *chip;
>    const sensors_feature *feature;
>    double current, min, max, critical;
>+   int users;
> };
> 
> static double
>@@ -193,11 +194,17 @@ static void
> free_query_data(void *p)
> {
>    struct sensors_temp_info *sti = (struct sensors_temp_info *) p;
>-   list_del(&sti->list);
>-   if (sti->chip)
>-      sensors_free_chip_name(sti->chip);
>-   FREE(sti);
>-   sensors_cleanup();
>+   if (--sti->users == 0) {
>+      list_del(&sti->list);
>+      gsensors_temp_count--;
>+      if (sti->chip)
>+         sensors_free_chip_name(sti->chip);
>+      FREE(sti);
>+   }
>+
>+   /* Destroy sensor singleton when after all refs released. */
>+   if (!gsensors_temp_count)
>+      sensors_cleanup();
> }
> 
> /**
>@@ -234,6 +241,7 @@ hud_sensors_temp_graph_install(struct hud_pane *pane, const char *dev_name,
>            sti->mode == SENSORS_POWER_CURRENT ? "Pow" :
>            sti->mode == SENSORS_TEMP_CRITICAL ? "Crit" : "Unkn");
> 
>+   sti->users++;
>    gr->query_data = sti;
>    gr->query_new_value = query_sti_load;
>

Actions: View | Splinter Review

Attachments on bug 98169: 127151 | 127217 | 127218 | 127222 | 127224 | 127225 | 127246 | 127250 | 127271

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.