Attachment 127407 Details for Bug 98306 – [PATCH] drm/i915: Refresh that status of MST capable connectors in ->detect()

[patch] [PATCH] drm/i915: Refresh that status of MST capable connectors in ->detect()

0001-drm-i915-Refresh-that-status-of-MST-capable-connecto.patch (text/plain), 2.24 KB, created by Ville Syrjala on 2016-10-19 17:29:22 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Ville Syrjala

Created: 2016-10-19 17:29:22 UTC

Size: 2.24 KB

patch

obsolete

>From 87d9d6a7591901b4dd42a651350095150466c077 Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?Ville=20Syrj=C3=A4l=C3=A4?= <ville.syrjala@linux.intel.com>
>Date: Wed, 19 Oct 2016 20:17:10 +0300
>Subject: [PATCH] drm/i915: Refresh that status of MST capable connectors in
> ->detect()
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>Once we've determined that the sink is MST capable we never end up
>running through the full detect cycle again, despite getting HPDs.
>Fix tht by ripping out the incorrect piece of code responsible.
>
>This got broken when I moved the long HPD handling to the ->detect()
>hook, but failed to remove the leftover code.
>
>Cc: Ander Conselvan de Oliveira <conselvan2@gmail.com>
>Cc: drm-intel-fixes@lists.freedesktop.org
>Cc: Rui Tiago Matos <tiagomatos@gmail.com>
>Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=98323
>Cc: Kirill A. Shutemov <kirill@shutemov.name>
>Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=98306
>Fixes: 27d4efc5591a ("drm/i915: Move long hpd handling into the hotplug work")
>Signed-off-by: Ville SyrjÃ¤lÃ¤ <ville.syrjala@linux.intel.com>
>---
> drivers/gpu/drm/i915/intel_dp.c | 10 ----------
> 1 file changed, 10 deletions(-)
>
>diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
>index 88f3b745a326..633e78c43fc3 100644
>--- a/drivers/gpu/drm/i915/intel_dp.c
>+++ b/drivers/gpu/drm/i915/intel_dp.c
>@@ -4478,21 +4478,11 @@ static enum drm_connector_status
> intel_dp_detect(struct drm_connector *connector, bool force)
> {
> 	struct intel_dp *intel_dp = intel_attached_dp(connector);
>-	struct intel_digital_port *intel_dig_port = dp_to_dig_port(intel_dp);
>-	struct intel_encoder *intel_encoder = &intel_dig_port->base;
> 	enum drm_connector_status status = connector->status;
> 
> 	DRM_DEBUG_KMS("[CONNECTOR:%d:%s]\n",
> 		      connector->base.id, connector->name);
> 
>-	if (intel_dp->is_mst) {
>-		/* MST devices are disconnected from a monitor POV */
>-		intel_dp_unset_edid(intel_dp);
>-		if (intel_encoder->type != INTEL_OUTPUT_EDP)
>-			intel_encoder->type = INTEL_OUTPUT_DP;
>-		return connector_status_disconnected;
>-	}
>-
> 	/* If full detect is not performed yet, do a full detect */
> 	if (!intel_dp->detect_done)
> 		status = intel_dp_long_pulse(intel_dp->attached_connector);
>-- 
>2.7.4
>

Actions: View | Splinter Review

Attachments on bug 98306: 127375 | 127407 | 127411 | 139228 | 141562

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.