Attachment 127435 Details for Bug 98040 – Don't allow polling in late suspend

[patch] Don't allow polling in late suspend

0001-drm-i915-vlv-Prevent-enabling-hpd-polling-in-late-su.patch (text/plain), 1.47 KB, created by Lyude Paul on 2016-10-20 19:49:18 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Lyude Paul

Created: 2016-10-20 19:49:18 UTC

Size: 1.47 KB

patch

obsolete

>From 3fd37a78a045c18b79cd3d2954b3716244a739b3 Mon Sep 17 00:00:00 2001
>From: Lyude <lyude@redhat.com>
>Date: Thu, 20 Oct 2016 15:42:00 -0400
>Subject: [PATCH] drm/i915/vlv: Prevent enabling hpd polling in late suspend
>Cc: off
>
>One of the CI machines began to run into issues with the hpd poller
>suddenly waking up in the midst of the late suspend phase. It looks like
>this is getting caused by the fact we now deinitialize power wells in
>late suspend, which means that intel_hpd_poll_init() gets called in late
>suspend causing polling to get re-enabled. So, when deinitializing power
>wells on valleyview we now refrain from enabling polling in the midst of
>suspend.
>
>Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=98040
>Signed-off-by: Lyude <lyude@redhat.com>
>---
> drivers/gpu/drm/i915/intel_runtime_pm.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
>diff --git a/drivers/gpu/drm/i915/intel_runtime_pm.c b/drivers/gpu/drm/i915/intel_runtime_pm.c
>index ee56a87..21bf1d5 100644
>--- a/drivers/gpu/drm/i915/intel_runtime_pm.c
>+++ b/drivers/gpu/drm/i915/intel_runtime_pm.c
>@@ -1138,7 +1138,9 @@ static void vlv_display_power_well_deinit(struct drm_i915_private *dev_priv)
> 
> 	intel_power_sequencer_reset(dev_priv);
> 
>-	intel_hpd_poll_init(dev_priv);
>+	/* Prevent us from re-enabling polling on accident in late suspend */
>+	if (!dev_priv->drm.dev->power.is_suspended)
>+		intel_hpd_poll_init(dev_priv);
> }
> 
> static void vlv_display_power_well_enable(struct drm_i915_private *dev_priv,
>-- 
>2.7.4
>

Actions: View | Splinter Review

Attachments on bug 98040: 127097 | 127209 | 127435

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.