Attachment 127580 Details for Bug 98282 – dirty after cleanup

[patch] dirty after cleanup

dirty.diff (text/plain), 1.59 KB, created by Mika Kuoppala on 2016-10-28 08:12:37 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Mika Kuoppala

Created: 2016-10-28 08:12:37 UTC

Size: 1.59 KB

patch

obsolete

>diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915/i915_gem_gtt.c
>index 947d5ad5..94771b6a 100644
>--- a/drivers/gpu/drm/i915/i915_gem_gtt.c
>+++ b/drivers/gpu/drm/i915/i915_gem_gtt.c
>@@ -846,6 +846,16 @@ static void gen8_ppgtt_clear_pml4(struct i915_address_space *vm,
> 	}
> }
> 
>+/* PDE TLBs are a pain to invalidate on GEN8+. When we modify
>+ * the page table structures, we mark them dirty so that
>+ * context switching/execlist queuing code takes extra steps
>+ * to ensure that tlbs are flushed.
>+ */
>+static void mark_tlbs_dirty(struct i915_hw_ppgtt *ppgtt)
>+{
>+	ppgtt->pd_dirty_rings = INTEL_INFO(ppgtt->base.dev)->ring_mask;
>+}
>+
> static void gen8_ppgtt_clear_range(struct i915_address_space *vm,
> 				   uint64_t start, uint64_t length)
> {
>@@ -855,6 +865,8 @@ static void gen8_ppgtt_clear_range(struct i915_address_space *vm,
> 		gen8_ppgtt_clear_pml4(vm, &ppgtt->pml4, start, length);
> 	else
> 		gen8_ppgtt_clear_pdp(vm, &ppgtt->pdp, start, length);
>+
>+	mark_tlbs_dirty(ppgtt);
> }
> 
> static void
>@@ -1280,16 +1292,6 @@ int __must_check alloc_gen8_temp_bitmaps(unsigned long **new_pds,
> 	return -ENOMEM;
> }
> 
>-/* PDE TLBs are a pain to invalidate on GEN8+. When we modify
>- * the page table structures, we mark them dirty so that
>- * context switching/execlist queuing code takes extra steps
>- * to ensure that tlbs are flushed.
>- */
>-static void mark_tlbs_dirty(struct i915_hw_ppgtt *ppgtt)
>-{
>-	ppgtt->pd_dirty_rings = INTEL_INFO(ppgtt->base.dev)->ring_mask;
>-}
>-
> static int gen8_alloc_va_range_3lvl(struct i915_address_space *vm,
> 				    struct i915_page_directory_pointer *pdp,
> 				    uint64_t start,

Actions: View | Splinter Review

Attachments on bug 98282: 127336 | 127337 | 127338 | 127339 | 127580 | 127642 | 127706

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.