Attachment 127649 Details for Bug 98519 – Patch to xdg-screensaver to fix suspending with window ID where the window has no name

[patch] Patch to xdg-screensaver to fix suspending with window ID where the window has no name

0005-xdg-screensaver-fix-suspending-using-window-without-.patch (text/plain), 1.03 KB, created by Reuben Thomas on 2016-10-31 19:58:06 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Reuben Thomas

Created: 2016-10-31 19:58:06 UTC

Size: 1.03 KB

patch

obsolete

>From 4d314789c9c041d424faba2a76217abd3adaba8c Mon Sep 17 00:00:00 2001
>From: Reuben Thomas <rrt@sc3d.org>
>Date: Mon, 31 Oct 2016 19:53:13 +0000
>Subject: [PATCH 5/5] xdg-screensaver: fix suspending using window without a
> WM_NAME property
>
>---
> scripts/xdg-screensaver.in | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
>diff --git a/scripts/xdg-screensaver.in b/scripts/xdg-screensaver.in
>index 50ef916..1651bf0 100644
>--- a/scripts/xdg-screensaver.in
>+++ b/scripts/xdg-screensaver.in
>@@ -466,8 +466,9 @@ my $x = X11::Protocol->new();
> my $named_window_id = hex($window_id);
> my $window_name;
> while (1) {
>-  ($window_name) = $x->GetProperty($named_window_id, $x->atom("WM_NAME"),
>-				   $x->atom("STRING"), 0, 1000, 0);
>+  eval { ($window_name) = $x->GetProperty($named_window_id, $x->atom("WM_NAME"),
>+				   $x->atom("STRING"), 0, 1000, 0); };
>+  $window_name = "?" if $@;
>   last if defined($window_name) && $window_name ne "";
>   (undef, $named_window_id) = $x->QueryTree($named_window_id);
>   if (!defined($named_window_id)) {
>-- 
>2.7.4
>

Actions: View | Splinter Review

Attachments on bug 98519: 127649

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.