Attachment 127678 Details for Bug 98505 – amdgpu patch that checks whether the new interface can be used for PM

[patch] amdgpu patch that checks whether the new interface can be used for PM

linux-v4.9-rc3-243-g0c183d9-amdgpu-atpx-legacy.patch (text/plain), 1.38 KB, created by Peter Wu on 2016-11-01 23:31:40 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Peter Wu

Created: 2016-11-01 23:31:40 UTC

Size: 1.38 KB

patch

obsolete

>diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_atpx_handler.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_atpx_handler.c
>index dae35a9..95c0244 100644
>--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_atpx_handler.c
>+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_atpx_handler.c
>@@ -34,6 +34,7 @@ struct amdgpu_atpx {
> 
> static struct amdgpu_atpx_priv {
> 	bool atpx_detected;
>+	bool bridge_pm_usable;
> 	/* handle for device - and atpx */
> 	acpi_handle dhandle;
> 	acpi_handle other_handle;
>@@ -205,7 +206,8 @@ static int amdgpu_atpx_validate(struct amdgpu_atpx *atpx)
> 	atpx->is_hybrid = false;
> 	if (valid_bits & ATPX_MS_HYBRID_GFX_SUPPORTED) {
> 		printk("ATPX Hybrid Graphics\n");
>-		atpx->functions.power_cntl = false;
>+		/* Disable legacy PM methods only when pcie port PM is usable. */
>+		atpx->functions.power_cntl = !amdgpu_atpx_priv->bridge_pm_usable;
> 		atpx->is_hybrid = true;
> 	}
> 
>@@ -480,6 +482,7 @@ static int amdgpu_atpx_power_state(enum vga_switcheroo_client_id id,
>  */
> static bool amdgpu_atpx_pci_probe_handle(struct pci_dev *pdev)
> {
>+	struct pci_dev *parent_pdev = pci_upstream_bridge(pdev);
> 	acpi_handle dhandle, atpx_handle;
> 	acpi_status status;
> 
>@@ -494,6 +497,7 @@ static bool amdgpu_atpx_pci_probe_handle(struct pci_dev *pdev)
> 	}
> 	amdgpu_atpx_priv.dhandle = dhandle;
> 	amdgpu_atpx_priv.atpx.handle = atpx_handle;
>+	amdgpu_atpx_priv.bridge_pm_usable = parent_pdev && parent_pdev->bridge_d3;
> 	return true;
> }
>

Actions: View | Splinter Review

Attachments on bug 98505: 127673 | 127678 | 127944 | 127953 | 127954 | 128042 | 128064 | 128075 | 128076

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.