Attachment 127736 Details for Bug 98276 – possible fix

[patch] possible fix

0001-drm-amdgpu-fix-crash-in-acp_hw_fini.patch (text/plain), 1.16 KB, created by Alex Deucher on 2016-11-03 21:52:52 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Alex Deucher

Created: 2016-11-03 21:52:52 UTC

Size: 1.16 KB

patch

obsolete

>From 8cb3631b9d84ae7266b4e3c331490c6ef78a1086 Mon Sep 17 00:00:00 2001
>From: Alex Deucher <alexander.deucher@amd.com>
>Date: Thu, 3 Nov 2016 17:47:51 -0400
>Subject: [PATCH] drm/amdgpu: fix crash in acp_hw_fini
>
>On CZ/ST systems with AZ rather than ACP audio, we need to bail
>early in hw_fini since there is nothing to do.
>
>bug: https://bugs.freedesktop.org/show_bug.cgi?id=98276
>
>Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
>Cc: stable@vger.kernel.org
>---
> drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
>diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c
>index 176c3d7..1130f9d 100644
>--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c
>+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c
>@@ -395,9 +395,12 @@ static int acp_hw_fini(void *handle)
> {
> 	int i, ret;
> 	struct device *dev;
>-
> 	struct amdgpu_device *adev = (struct amdgpu_device *)handle;
> 
>+	/* return early if no ACP */
>+	if (!adev->acp.acp_genpd)
>+		return 0;
>+
> 	for (i = 0; i < ACP_DEVS ; i++) {
> 		dev = get_mfd_cell_dev(adev->acp.acp_cell[i].name, i);
> 		ret = pm_genpd_remove_device(&adev->acp.acp_genpd->gpd, dev);
>-- 
>2.5.5
>

Actions: View | Splinter Review

Attachments on bug 98276: 127488 | 127736

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.