Attachment 128084 Details for Bug 98005 – ntsc rate fix, seems solid but not pretty.

[patch] ntsc rate fix, seems solid but not pretty.

vce-ntsc-rate-control-v2-diff (text/plain), 2.74 KB, created by Andy Furniss on 2016-11-20 14:03:21 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Andy Furniss

Created: 2016-11-20 14:03:21 UTC

Size: 2.74 KB

patch

obsolete

>diff --git a/src/gallium/state_trackers/va/picture.c b/src/gallium/state_trackers/va/picture.c
>index a8102a4..e32075c 100644
>--- a/src/gallium/state_trackers/va/picture.c
>+++ b/src/gallium/state_trackers/va/picture.c
>@@ -119,14 +119,32 @@ getEncParamPreset(vlVaContext *context)
>    context->desc.h264enc.rate_ctrl.fill_data_enable = 1;
>    context->desc.h264enc.rate_ctrl.enforce_hrd = 1;
>    context->desc.h264enc.enable_vui = false;
>-   if (context->desc.h264enc.rate_ctrl.frame_rate_num == 0)
>-      context->desc.h264enc.rate_ctrl.frame_rate_num = 30;
>-   context->desc.h264enc.rate_ctrl.target_bits_picture =
>-      context->desc.h264enc.rate_ctrl.target_bitrate / context->desc.h264enc.rate_ctrl.frame_rate_num;
>-   context->desc.h264enc.rate_ctrl.peak_bits_picture_integer =
>-      context->desc.h264enc.rate_ctrl.peak_bitrate / context->desc.h264enc.rate_ctrl.frame_rate_num;
>-   context->desc.h264enc.rate_ctrl.peak_bits_picture_fraction = 0;
>+   if (context->desc.h264enc.rate_ctrl.frame_rate_num == 0 ||
>+       context->desc.h264enc.rate_ctrl.frame_rate_den == 0) {
>+         context->desc.h264enc.rate_ctrl.frame_rate_num = 30;
>+         context->desc.h264enc.rate_ctrl.frame_rate_den = 1;
>+   }
>+   if (context->desc.h264enc.rate_ctrl.frame_rate_den > 1) {
>+      context->desc.h264enc.rate_ctrl.target_bits_picture =
>+         context->desc.h264enc.rate_ctrl.target_bitrate /
>+         (context->desc.h264enc.rate_ctrl.frame_rate_num /
>+         context->desc.h264enc.rate_ctrl.frame_rate_den + 1);
>+      context->desc.h264enc.rate_ctrl.peak_bits_picture_integer =
>+         context->desc.h264enc.rate_ctrl.peak_bitrate /
>+         (context->desc.h264enc.rate_ctrl.frame_rate_num /
>+         context->desc.h264enc.rate_ctrl.frame_rate_den + 1);
>+   } else {
>+      context->desc.h264enc.rate_ctrl.target_bits_picture =
>+         context->desc.h264enc.rate_ctrl.target_bitrate /
>+         (context->desc.h264enc.rate_ctrl.frame_rate_num /
>+         context->desc.h264enc.rate_ctrl.frame_rate_den);
>+      context->desc.h264enc.rate_ctrl.peak_bits_picture_integer =
>+         context->desc.h264enc.rate_ctrl.peak_bitrate /
>+         (context->desc.h264enc.rate_ctrl.frame_rate_num /
>+         context->desc.h264enc.rate_ctrl.frame_rate_den);
>+   }
> 
>+   context->desc.h264enc.rate_ctrl.peak_bits_picture_fraction = 0;
>    context->desc.h264enc.ref_pic_mode = 0x00000201;
> }
> 
>@@ -353,7 +371,7 @@ handleVAEncSequenceParameterBufferType(vlVaDriver *drv, vlVaContext *context, vl
>    }
>    context->desc.h264enc.gop_size = h264->intra_idr_period;
>    context->desc.h264enc.rate_ctrl.frame_rate_num = h264->time_scale / 2;
>-   context->desc.h264enc.rate_ctrl.frame_rate_den = 1;
>+   context->desc.h264enc.rate_ctrl.frame_rate_den = h264->num_units_in_tick;
>    return VA_STATUS_SUCCESS;
> }
>

Actions: View | Splinter Review

Attachments on bug 98005: 127943 | 128084 | 128354

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.