Attachment 128472 Details for Bug 98914 – Possible fix

[patch] Possible fix

0001-vl-zscan-fix-Fix-trivial-sign-compare-warnings.patch (text/plain), 1.42 KB, created by Christian König on 2016-12-14 14:06:41 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Christian König

Created: 2016-12-14 14:06:41 UTC

Size: 1.42 KB

patch

obsolete

>From 42ee1fca73fb656eccf6512a454a7096277b0ea0 Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?Christian=20K=C3=B6nig?= <christian.koenig@amd.com>
>Date: Wed, 14 Dec 2016 15:03:35 +0100
>Subject: [PATCH] vl/zscan: fix "Fix trivial sign compare warnings"
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>The variable actually needs to be signed, otherwise converting it to a
>float doesn't work as expected.
>
>Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=98914
>Signed-off-by: Christian KÃ¶nig <christian.koenig@amd.com>
>---
> src/gallium/auxiliary/vl/vl_zscan.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/src/gallium/auxiliary/vl/vl_zscan.c b/src/gallium/auxiliary/vl/vl_zscan.c
>index ef05af4..24d6452 100644
>--- a/src/gallium/auxiliary/vl/vl_zscan.c
>+++ b/src/gallium/auxiliary/vl/vl_zscan.c
>@@ -152,7 +152,7 @@ create_vert_shader(struct vl_zscan *zscan)
>    for (i = 0; i < zscan->num_channels; ++i) {
>       ureg_ADD(shader, ureg_writemask(tmp, TGSI_WRITEMASK_X), ureg_scalar(ureg_src(tmp), TGSI_SWIZZLE_Y),
>                ureg_imm1f(shader, 1.0f / (zscan->blocks_per_line * VL_BLOCK_WIDTH)
>-                * (i - (signed)zscan->num_channels / 2)));
>+                * ((signed)i - (signed)zscan->num_channels / 2)));
> 
>       ureg_MAD(shader, ureg_writemask(o_vtex[i], TGSI_WRITEMASK_X), vrect,
>                ureg_imm1f(shader, 1.0f / zscan->blocks_per_line), ureg_src(tmp));
>-- 
>2.7.4
>

Actions: View | Splinter Review

Attachments on bug 98914: 128286 | 128287 | 128288 | 128472

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.