Attachment 128483 Details for Bug 99094 – doc: Clarify when the device scale is inherited and when it isn't

[patch] doc: Clarify when the device scale is inherited and when it isn't

0002-doc-Clarify-when-the-device-scale-is-inherited-and-w.patch (text/plain), 2.16 KB, created by Debarshi Ray on 2016-12-15 11:50:41 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Debarshi Ray

Created: 2016-12-15 11:50:41 UTC

Size: 2.16 KB

patch

obsolete

>From aef8ead069245fceb808fe8a9dfdcb12424b202e Mon Sep 17 00:00:00 2001
>From: Debarshi Ray <debarshir@freedesktop.org>
>Date: Thu, 15 Dec 2016 12:50:13 +0100
>Subject: [PATCH 2/2] doc: Clarify when the device scale is inherited and when
> it isn't
>
>In short, cairo_surface_create_similar inherits it, while
>cairo_surface_create_similar_image doesn't. It wasn't obvious without
>reading the code or explicitly checking the device scale of the new
>surface.
>
>Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=99094
>---
> src/cairo-surface.c | 13 ++++++++-----
> 1 file changed, 8 insertions(+), 5 deletions(-)
>
>diff --git a/src/cairo-surface.c b/src/cairo-surface.c
>index f56e0f81c09a..fc5f876d70ef 100644
>--- a/src/cairo-surface.c
>+++ b/src/cairo-surface.c
>@@ -466,10 +466,11 @@ _cairo_surface_copy_similar_properties (cairo_surface_t *surface,
>  *
>  * Create a new surface that is as compatible as possible with an
>  * existing surface. For example the new surface will have the same
>- * fallback resolution and font options as @other. Generally, the new
>- * surface will also use the same backend as @other, unless that is
>- * not possible for some reason. The type of the returned surface may
>- * be examined with cairo_surface_get_type().
>+ * device scale, fallback resolution and font options as
>+ * @other. Generally, the new surface will also use the same backend
>+ * as @other, unless that is not possible for some reason. The type of
>+ * the returned surface may be examined with
>+ * cairo_surface_get_type().
>  *
>  * Initially the surface contents are all 0 (transparent if contents
>  * have transparency, black otherwise.)
>@@ -556,7 +557,9 @@ cairo_surface_create_similar (cairo_surface_t  *other,
>  *
>  * Create a new image surface that is as compatible as possible for uploading
>  * to and the use in conjunction with an existing surface. However, this surface
>- * can still be used like any normal image surface.
>+ * can still be used like any normal image surface. Unlike
>+ * cairo_surface_create_similar() the new image surface won't inherit
>+ * the device scale from @other.
>  *
>  * Initially the surface contents are all 0 (transparent if contents
>  * have transparency, black otherwise.)
>-- 
>2.7.4
>

Actions: View | Splinter Review

Attachments on bug 99094: 128482 | 128483

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.