Attachment 128883 Details for Bug 99357 – Patch to fix it

[patch] Patch to fix it

pop.diff (text/plain), 982 bytes, created by Christoph Cullmann on 2017-01-11 09:03:25 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Christoph Cullmann

Created: 2017-01-11 09:03:25 UTC

Size: 982 bytes

patch

obsolete

>diff --git a/qt5/src/poppler-link.cc b/qt5/src/poppler-link.cc
>index 477f228..5a4df1a 100644
>--- a/qt5/src/poppler-link.cc
>+++ b/qt5/src/poppler-link.cc
>@@ -296,7 +296,8 @@ class LinkMoviePrivate : public LinkPrivate
> 	LinkDestination::LinkDestination(const QString &description)
> 		: d( new LinkDestinationPrivate )
> 	{
>-		QStringList tokens = description.split( ';' );
>+		const QStringList tokens = description.split( ';' );
>+                if (tokens.size() >= 10) {
>                     d->kind = static_cast<Kind>(tokens.at(0).toInt());
>                     d->pageNum = tokens.at(1).toInt();
>                     d->left = tokens.at(2).toDouble();
>@@ -308,6 +309,7 @@ class LinkMoviePrivate : public LinkPrivate
>                     d->changeTop = static_cast<bool>(tokens.at(8).toInt());
>                     d->changeZoom = static_cast<bool>(tokens.at(9).toInt());
>                 }
>+	}
> 
> 	LinkDestination::LinkDestination(const LinkDestination &other)
> 		: d( other.d )

Actions: View | Splinter Review

Attachments on bug 99357: 128883

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.