Attachment 129145 Details for Bug 99524 – possible fix

[patch] possible fix

0001-Revert-drm-radeon-always-apply-pci-shutdown-callback.patch (text/plain), 1.21 KB, created by Alex Deucher on 2017-01-25 17:05:35 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Alex Deucher

Created: 2017-01-25 17:05:35 UTC

Size: 1.21 KB

patch

obsolete

>From 631201060124d49b4e0910213987959756793db8 Mon Sep 17 00:00:00 2001
>From: Alex Deucher <alexander.deucher@amd.com>
>Date: Wed, 25 Jan 2017 12:00:29 -0500
>Subject: [PATCH] Revert "drm/radeon: always apply pci shutdown callbacks"
>
>This seems to break reboot on some evergreen systems.
>
>bugs:
>https://bugs.freedesktop.org/show_bug.cgi?id=99524
>https://bugzilla.kernel.org/show_bug.cgi?id=192271
>
>This reverts commit a481daa88fd4d6b54f25348972bba10b5f6a84d0.
>---
> drivers/gpu/drm/radeon/radeon_drv.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
>diff --git a/drivers/gpu/drm/radeon/radeon_drv.c b/drivers/gpu/drm/radeon/radeon_drv.c
>index af3bbe8..87476ad 100644
>--- a/drivers/gpu/drm/radeon/radeon_drv.c
>+++ b/drivers/gpu/drm/radeon/radeon_drv.c
>@@ -366,11 +366,10 @@ static void
> radeon_pci_shutdown(struct pci_dev *pdev)
> {
> 	/* if we are running in a VM, make sure the device
>-	 * torn down properly on reboot/shutdown.
>-	 * unfortunately we can't detect certain
>-	 * hypervisors so just do this all the time.
>+	 * torn down properly on reboot/shutdown
> 	 */
>-	radeon_pci_remove(pdev);
>+	if (radeon_device_is_virtual())
>+		radeon_pci_remove(pdev);
> }
> 
> static int radeon_pmops_suspend(struct device *dev)
>-- 
>2.5.5
>

Actions: View | Splinter Review

Attachments on bug 99524: 129131 | 129145

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.