Attachment 129427 Details for Bug 99724 – test: Add some OOM paths to the test-pending-call-timeout test

[patch] test: Add some OOM paths to the test-pending-call-timeout test

test-Add-some-OOM-paths-to-the-test-pending-call-t.patch (text/plain), 1.43 KB, created by Philip Withnall on 2017-02-09 09:47:18 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Philip Withnall

Created: 2017-02-09 09:47:18 UTC

Size: 1.43 KB

patch

obsolete

>From 557152bb28feed800cd7f18333155ce73ed3529f Mon Sep 17 00:00:00 2001
>From: Philip Withnall <withnall@endlessm.com>
>Date: Thu, 9 Feb 2017 09:45:59 +0000
>Subject: [PATCH] test: Add some OOM paths to the test-pending-call-timeout
> test
>
>This is mostly pointless, but will shut Coverity up.
>
>Coverity ID: 54718
>
>Signed-off-by: Philip Withnall <withnall@endlessm.com>
>
>https://bugs.freedesktop.org/show_bug.cgi?id=99724
>---
> test/name-test/test-pending-call-timeout.c | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
>diff --git a/test/name-test/test-pending-call-timeout.c b/test/name-test/test-pending-call-timeout.c
>index 6035df8..a204db0 100644
>--- a/test/name-test/test-pending-call-timeout.c
>+++ b/test/name-test/test-pending-call-timeout.c
>@@ -25,8 +25,13 @@ _method_call (DBusConnection *conn,
>                                          "org.freedesktop.TestSuite",
>                                          "DelayEcho");
> 
>-  dbus_message_append_args (method, DBUS_TYPE_STRING, &echo, NULL);
>-  dbus_connection_send_with_reply (conn, method, &pending, timeout_milliseconds);
>+  if (method == NULL ||
>+      !dbus_message_append_args (method, DBUS_TYPE_STRING, &echo, NULL) ||
>+      !dbus_connection_send_with_reply (conn, method, &pending, timeout_milliseconds))
>+    {
>+      printf ("Bail out! OOM when building and sending message ***\n");
>+      exit (1);
>+    }
>   dbus_message_unref (method);
>   
>   /* block on the message */
>-- 
>2.9.3

Actions: View | Splinter Review

Attachments on bug 99724: 129427 | 129428 | 129429 | 129430 | 129474 | 129475

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.