Attachment 129442 Details for Bug 98404 – [PATCH 3/3] UpKbdBacklight: Try the new brightness_hw_changed attr and watch for POLL_PRI

[patch] [PATCH 3/3] UpKbdBacklight: Try the new brightness_hw_changed attr and watch for POLL_PRI

0003-UpKbdBacklight-Try-the-new-brightness_hw_changed-att.patch (text/plain), 3.17 KB, created by Hans de Goede on 2017-02-09 16:10:34 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Hans de Goede

Created: 2017-02-09 16:10:34 UTC

Size: 3.17 KB

patch

obsolete

>From b6991b91a6e485d1e8fd9a80f369b6e9138c3791 Mon Sep 17 00:00:00 2001
>From: Hans de Goede <hdegoede@redhat.com>
>Date: Sun, 16 Oct 2016 12:53:19 +0200
>Subject: [PATCH 3/3] UpKbdBacklight: Try the new brightness_hw_changed attr
> and watch for POLL_PRI
>
>4.11 and later kernels [1] have a brightness_hw_changed attribute which
>can be polled to detect hardware initiated brightness changes, such as
>done by e.g. hardwired (firmware handled) keyboard backlight brightness
>control hotkeys.
>
>[1] https://patchwork.kernel.org/patch/9544111/
>---
> src/up-kbd-backlight.c | 35 +++++++++++++++++++++++++++++++++++
> 1 file changed, 35 insertions(+)
>
>diff --git a/src/up-kbd-backlight.c b/src/up-kbd-backlight.c
>index 57d9524..6817898 100644
>--- a/src/up-kbd-backlight.c
>+++ b/src/up-kbd-backlight.c
>@@ -43,7 +43,9 @@ static void     up_kbd_backlight_finalize   (GObject	*object);
> struct UpKbdBacklightPrivate
> {
> 	gint			 fd;
>+	gint			 fd_hw_changed;
> 	gint			 max_brightness;
>+	GIOChannel		*channel;
> };
> 
> G_DEFINE_TYPE (UpKbdBacklight, up_kbd_backlight, UP_TYPE_EXPORTED_KBD_BACKLIGHT_SKELETON)
>@@ -210,6 +212,24 @@ up_kbd_backlight_class_init (UpKbdBacklightClass *klass)
> }
> 
> /**
>+ * up_kbd_backlight_event_io:
>+ **/
>+static gboolean
>+up_kbd_backlight_event_io (GIOChannel *channel, GIOCondition condition, gpointer data)
>+{
>+	UpKbdBacklight *kbd_backlight = (UpKbdBacklight*) data;
>+	gint brightness;
>+
>+	if (!(condition & G_IO_PRI))
>+		return FALSE;
>+
>+	brightness = up_kbd_backlight_brightness_read (kbd_backlight, kbd_backlight->priv->fd_hw_changed);
>+	up_kbd_backlight_emit_change (kbd_backlight, brightness, "hotkey");
>+
>+	return TRUE;
>+}
>+
>+/**
>  * up_kbd_backlight_find:
>  **/
> static gboolean
>@@ -223,6 +243,7 @@ up_kbd_backlight_find (UpKbdBacklight *kbd_backlight)
> 	gchar *dir_path = NULL;
> 	gchar *path_max = NULL;
> 	gchar *path_now = NULL;
>+	gchar *path_hw_changed = NULL;
> 	gchar *buf_max = NULL;
> 	gchar *buf_now = NULL;
> 	GError *error = NULL;
>@@ -273,6 +294,13 @@ up_kbd_backlight_find (UpKbdBacklight *kbd_backlight)
> 	if (up_kbd_backlight_brightness_read (kbd_backlight, kbd_backlight->priv->fd) < 0)
> 		goto out;
> 
>+	path_hw_changed = g_build_filename (dir_path, "brightness_hw_changed", NULL);
>+	kbd_backlight->priv->fd_hw_changed = open (path_hw_changed, O_RDONLY);
>+	if (kbd_backlight->priv->fd_hw_changed >= 0) {
>+		kbd_backlight->priv->channel = g_io_channel_unix_new (kbd_backlight->priv->fd_hw_changed);
>+		g_io_add_watch (kbd_backlight->priv->channel, G_IO_PRI, up_kbd_backlight_event_io, kbd_backlight);
>+	}
>+
> 	/* success */
> 	found = TRUE;
> out:
>@@ -281,6 +309,7 @@ out:
> 	g_free (dir_path);
> 	g_free (path_max);
> 	g_free (path_now);
>+	g_free (path_hw_changed);
> 	g_free (buf_max);
> 	g_free (buf_now);
> 	return found;
>@@ -316,6 +345,12 @@ up_kbd_backlight_finalize (GObject *object)
> 	kbd_backlight = UP_KBD_BACKLIGHT (object);
> 	kbd_backlight->priv = UP_KBD_BACKLIGHT_GET_PRIVATE (kbd_backlight);
> 
>+	if (kbd_backlight->priv->channel) {
>+		g_io_channel_shutdown (kbd_backlight->priv->channel, FALSE, NULL);
>+		g_io_channel_unref (kbd_backlight->priv->channel);
>+		close (kbd_backlight->priv->fd_hw_changed);
>+	}
>+
> 	/* close file */
> 	if (kbd_backlight->priv->fd >= 0)
> 		close (kbd_backlight->priv->fd);
>-- 
>2.9.3
>

Actions: View | Splinter Review

Attachments on bug 98404: 127509 | 127510 | 128051 | 128052 | 129440 | 129441 | 129442 | 129640 | 129641 | 129642 | 129644 | 129645 | 129646

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.