Attachment 129454 Details for Bug 99741 – 0007-Fix-error-handling-in-polkit_authority_enumerate_tem.patch

[patch] 0007-Fix-error-handling-in-polkit_authority_enumerate_tem.patch

0007-Fix-error-handling-in-polkit_authority_enumerate_tem.patch (text/plain), 1.31 KB, created by Miloslav Trmac on 2017-02-09 19:35:22 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Miloslav Trmac

Created: 2017-02-09 19:35:22 UTC

Size: 1.31 KB

patch

obsolete

>From c751320a1bb4f81e94175aa89707ea5a0d594802 Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?Miloslav=20Trma=C4=8D?= <mitr@redhat.com>
>Date: Thu, 9 Feb 2017 19:38:17 +0100
>Subject: [PATCH 7/9] Fix error handling in
> polkit_authority_enumerate_temporary_authorizations_finish
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>Fix memory leaks, and don't return a pointer to freed memory.
>
>https://bugs.freedesktop.org/show_bug.cgi?id=99741
>
>Signed-off-by: Miloslav TrmaÄ <mitr@redhat.com>
>---
> src/polkit/polkitauthority.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
>diff --git a/src/polkit/polkitauthority.c b/src/polkit/polkitauthority.c
>index b783c0e..404954f 100644
>--- a/src/polkit/polkitauthority.c
>+++ b/src/polkit/polkitauthority.c
>@@ -1698,11 +1698,13 @@ polkit_authority_enumerate_temporary_authorizations_finish (PolkitAuthority *aut
>           g_prefix_error (error, "Error serializing return value of EnumerateTemporaryAuthorizations: ");
>           g_list_foreach (ret, (GFunc) g_object_unref, NULL);
>           g_list_free (ret);
>-          goto out;
>+          ret = NULL;
>+          goto out_array;
>         }
>       ret = g_list_prepend (ret, auth);
>     }
>   ret = g_list_reverse (ret);
>+ out_array:
>   g_variant_unref (array);
>   g_variant_unref (value);
> 
>-- 
>2.7.4
>

Actions: View | Splinter Review

Attachments on bug 99741: 129448 | 129449 | 129450 | 129451 | 129452 | 129453 | 129454 | 129455 | 129456 | 130032 | 132124

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.