Attachment 129667 Details for Bug 99828 – shell-test: Don't use _dbus_get_tmpdir()

[patch] shell-test: Don't use _dbus_get_tmpdir()

0004-shell-test-Don-t-use-_dbus_get_tmpdir.patch (text/plain), 1.30 KB, created by Simon McVittie on 2017-02-16 13:03:20 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Simon McVittie

Created: 2017-02-16 13:03:20 UTC

Size: 1.30 KB

patch

obsolete

>From 3e92cbf175a9a3b568fee62a5d7f19e503441982 Mon Sep 17 00:00:00 2001
>From: Simon McVittie <simon.mcvittie@collabora.co.uk>
>Date: Wed, 15 Feb 2017 16:57:00 +0000
>Subject: [PATCH 4/4] shell-test: Don't use _dbus_get_tmpdir()
>
>There's no particular reason to be using a temporary directory (it's
>just some arbitrary string), and it will be harder for future changes
>to eradicate uses of a temporary directory that is shared between users
>if we list it here.
>
>Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
>---
> test/shell-test.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/test/shell-test.c b/test/shell-test.c
>index 07585abb..794757f3 100644
>--- a/test/shell-test.c
>+++ b/test/shell-test.c
>@@ -172,7 +172,7 @@ main (int argc, char **argv)
>   test_command_line ("/opt/gnome/bin/service-start", NULL);
>   test_command_line ("grep", "-l", "-r", "-i", "'whatever'", "files*.c", NULL);
>   test_command_line ("/home/boston/johnp/devel-local/dbus/test/test-segfault", NULL);
>-  test_command_line ("ls", "-l", "-a", "--colors", _dbus_get_tmpdir(), NULL);
>+  test_command_line ("ls", "-l", "-a", "--colors", NULL);
>   test_command_line ("rsync-to-server", NULL);
>   test_command_line ("test-segfault", "--no-segfault", NULL);
>   test_command_line ("evolution", "mailto:pepe@cuco.com", NULL);
>-- 
>2.11.0
>

Actions: View | Splinter Review

Attachments on bug 99828: 129643 | 129652 | 129653 | 129654 | 129655 | 129666 | 129667

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.