Attachment 129833 Details for Bug 99862 – daemon: more efficient poll resetting

[patch] daemon: more efficient poll resetting

daemon-more-efficient-poll-resetting.patch (text/plain), 1.03 KB, created by Christian Kellner on 2017-02-22 16:55:05 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Christian Kellner

Created: 2017-02-22 16:55:05 UTC

Size: 1.03 KB

patch

obsolete

>From 94fcd3c6088aba169843a3ac49ef990a5000f38f Mon Sep 17 00:00:00 2001
>From: Christian Kellner <christian@kellner.me>
>Date: Wed, 22 Feb 2017 17:46:11 +0100
>Subject: [PATCH] daemon: more efficient poll resetting
>
>If the poll timeout is actually changed because the warning level
>has changed, only reset the actual poll code, not the warning level
>notifications and the booking structures.
>
>https://bugs.freedesktop.org/show_bug.cgi?id=99862
>---
> src/up-daemon.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/src/up-daemon.c b/src/up-daemon.c
>index fd38640..4d2c835 100644
>--- a/src/up-daemon.c
>+++ b/src/up-daemon.c
>@@ -776,9 +776,9 @@ change_idle_timeout (UpDevice   *device,
> 		g_debug ("Resetting for polling for '%s' (warning-level change)",
> 			 up_device_get_object_path (device));
> 
>+		g_source_remove (data->id);
> 		data->timeout = timeout;
>-		up_daemon_stop_poll (G_OBJECT (device));
>-		up_daemon_start_poll (G_OBJECT (device), callback);
>+		enable_poll_for_device (device, data);
> 	}
> 
> 	g_object_unref (daemon);
>-- 
>2.9.3

Actions: View | Splinter Review

Attachments on bug 99862: 129831 | 129832 | 129833

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.