Attachment 130212 Details for Bug 99222 – Change sink priorities

[patch] Change sink priorities

0001-sink-Invert-priorities-to-prefer-external-devices.patch (text/plain), 1.62 KB, created by Christian Kellner on 2017-03-14 11:07:19 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Christian Kellner

Created: 2017-03-14 11:07:19 UTC

Size: 1.62 KB

patch

obsolete

>From f8c0eb3000f898b9d510bacde923038a09a3914e Mon Sep 17 00:00:00 2001
>From: Christian Kellner <christian@kellner.me>
>Date: Thu, 9 Mar 2017 15:51:49 +0100
>Subject: [PATCH] sink: Invert priorities to prefer external devices
>
>Currently internal > speaker > headphone and pic > usb > bluetooth.
>Invert both of these sets, with the reasoning that a headphone and
>speakers are something that a user has actively attached and should
>therefore get a higher priority. The same reasoning is applied for
>the bus type, i.e. bluetooth and usb should be higher then pic,
>because they most likely have been actively attached be a user.
>---
> src/pulsecore/sink.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
>diff --git a/src/pulsecore/sink.c b/src/pulsecore/sink.c
>index 6011f45..fb16d57 100644
>--- a/src/pulsecore/sink.c
>+++ b/src/pulsecore/sink.c
>@@ -3511,21 +3511,21 @@ unsigned pa_device_init_priority(pa_proplist *p) {
> 
>     if ((s = pa_proplist_gets(p, PA_PROP_DEVICE_FORM_FACTOR))) {
> 
>-        if (pa_streq(s, "internal"))
>+        if (pa_streq(s, "headphone"))
>             priority += 900;
>         else if (pa_streq(s, "speaker"))
>             priority += 500;
>-        else if (pa_streq(s, "headphone"))
>+        else if (pa_streq(s, "internal"))
>             priority += 400;
>     }
> 
>     if ((s = pa_proplist_gets(p, PA_PROP_DEVICE_BUS))) {
> 
>-        if (pa_streq(s, "pci"))
>+        if (pa_streq(s, "bluetooth"))
>             priority += 50;
>         else if (pa_streq(s, "usb"))
>             priority += 40;
>-        else if (pa_streq(s, "bluetooth"))
>+        else if (pa_streq(s, "pci"))
>             priority += 30;
>     }
> 
>-- 
>2.9.3
>

Actions: View | Splinter Review

Attachments on bug 99222: 130212

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.