Attachment 130535 Details for Bug 100452 – patch

patch

fix_push_constants_host_memory_leak.patch (text/plain), 1.40 KB, created by Craig Stout on 2017-03-29 15:52:35 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Craig Stout

Created: 2017-03-29 15:52:35 UTC

Size: 1.40 KB

patch

obsolete

>commit 9fc0a292f58a9426830ac83e385548483657c9dd
>Author: Craig Stout <cstout@google.com>
>Date:   Tue Mar 28 23:18:29 2017 -0700
>
>    Fix push_constants host memory leak
>    
>    Change-Id: I6fc921f9ddbd1c9f374f15f01b986ee923706e83
>
>diff --git a/src/intel/vulkan/anv_cmd_buffer.c b/src/intel/vulkan/anv_cmd_buffer.c
>index 44ae67d019..8cbeaa98e9 100644
>--- a/src/intel/vulkan/anv_cmd_buffer.c
>+++ b/src/intel/vulkan/anv_cmd_buffer.c
>@@ -118,7 +118,12 @@ anv_cmd_state_reset(struct anv_cmd_buffer *cmd_buffer)
>    struct anv_cmd_state *state = &cmd_buffer->state;
> 
>    memset(&state->descriptors, 0, sizeof(state->descriptors));
>-   memset(&state->push_constants, 0, sizeof(state->push_constants));
>+   for (uint32_t i = 0; i < MESA_SHADER_STAGES; i++) {
>+      if (state->push_constants[i] != NULL) {
>+         vk_free(&cmd_buffer->pool->alloc, state->push_constants[i]);
>+         state->push_constants[i] = NULL;
>+      }
>+   }
>    memset(state->binding_tables, 0, sizeof(state->binding_tables));
>    memset(state->samplers, 0, sizeof(state->samplers));
> 
>@@ -236,6 +241,9 @@ static VkResult anv_create_cmd_buffer(
>    if (cmd_buffer == NULL)
>       return vk_error(VK_ERROR_OUT_OF_HOST_MEMORY);
> 
>+   for (uint32_t i = 0; i < MESA_SHADER_STAGES; i++) {
>+      cmd_buffer->state.push_constants[i] = NULL;
>+   }
>    cmd_buffer->_loader_data.loaderMagic = ICD_LOADER_MAGIC;
>    cmd_buffer->device = device;
>    cmd_buffer->pool = pool;

Actions: View

Attachments on bug 100452: 130535

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.