Attachment 130689 Details for Bug 100579 – sink: Add portable form factor priority (450)

[patch] sink: Add portable form factor priority (450)

sink-Add-portable-form-factor-priority-450.patch (text/plain), 1.20 KB, created by Christian Kellner on 2017-04-05 12:17:42 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Christian Kellner

Created: 2017-04-05 12:17:42 UTC

Size: 1.20 KB

patch

obsolete

>From 840e6afb688e0962f052317db821d6ce786882b2 Mon Sep 17 00:00:00 2001
>From: Christian Kellner <christian@kellner.me>
>Date: Wed, 5 Apr 2017 13:52:27 +0200
>Subject: [PATCH] sink: Add portable form factor priority (450)
>
>The 'portable' form factor was currently missing meaning it is not
>getting any form-factor priority at all and it would therefore always
>be ranked lower then internal devices (which receive 400 form factor
>priority). The priority 450 is smaller then 'speaker', based on the
>idea that a portable device might have less quality then a dedicated
>'speaker' device (some Yamaha amplifiers announce themselves as such).
>
>https://bugs.freedesktop.org/show_bug.cgi?id=100579
>---
> src/pulsecore/sink.c | 2 ++
> 1 file changed, 2 insertions(+)
>
>diff --git a/src/pulsecore/sink.c b/src/pulsecore/sink.c
>index fb16d57..562f07f 100644
>--- a/src/pulsecore/sink.c
>+++ b/src/pulsecore/sink.c
>@@ -3515,6 +3515,8 @@ unsigned pa_device_init_priority(pa_proplist *p) {
>             priority += 900;
>         else if (pa_streq(s, "speaker"))
>             priority += 500;
>+        else if (pa_streq(s, "portable"))
>+            priority += 450;
>         else if (pa_streq(s, "internal"))
>             priority += 400;
>     }
>-- 
>2.9.3

Actions: View | Splinter Review

Attachments on bug 100579: 130689 | 130690

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.