Attachment 130802 Details for Bug 100620 – Patch to restrict VkDeviceMemory object size.

[patch] Patch to restrict VkDeviceMemory object size.

0001-anv-Limit-VkDeviceMemory-objects-to-2GB.patch (text/plain), 1.79 KB, created by Jason Ekstrand on 2017-04-11 16:04:51 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jason Ekstrand

Created: 2017-04-11 16:04:51 UTC

Size: 1.79 KB

patch

obsolete

>From 0a690c6e908b4360b95c65eaa254cdc965ac54b9 Mon Sep 17 00:00:00 2001
>From: Jason Ekstrand <jason.ekstrand@intel.com>
>Date: Tue, 11 Apr 2017 08:33:19 -0700
>Subject: [PATCH] anv: Limit VkDeviceMemory objects to 2GB
>
>---
> src/intel/vulkan/anv_device.c | 17 +++++++++++++++++
> 1 file changed, 17 insertions(+)
>
>diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c
>index 35ef4c4..b24c739 100644
>--- a/src/intel/vulkan/anv_device.c
>+++ b/src/intel/vulkan/anv_device.c
>@@ -1539,6 +1539,23 @@ VkResult anv_AllocateMemory(
>    assert(pAllocateInfo->memoryTypeIndex == 0 ||
>           (!device->info.has_llc && pAllocateInfo->memoryTypeIndex < 2));
> 
>+   /* The kernel relocation API has a limitation of a 32-bit delta value
>+    * applied to the address before it is written which, in spite of it being
>+    * unsigned, is treated as signed .  Because of the way that this maps to
>+    * the Vulkan API, we cannot handle an offset into a buffer that does not
>+    * fit into a signed 31 bits.  The only mechanism we have for dealing with
>+    * this at the moment is to limit all VkDeviceMemory objects to a maximum
>+    * of 2GB each.  The Vulkan spec allows us to do this:
>+    *
>+    *    "Some platforms may have a limit on the maximum size of a single
>+    *    allocation. For example, certain systems may fail to create
>+    *    allocations with a size greater than or equal to 4GB. Such a limit is
>+    *    implementation-dependent, and if such a failure occurs then the error
>+    *    VK_ERROR_OUT_OF_DEVICE_MEMORY should be returned."
>+    */
>+   if (pAllocationInfo->allocationSize > (1ull << 31))
>+      return VK_ERROR_OUT_OF_HOST_MEMORY;
>+
>    /* FINISHME: Fail if allocation request exceeds heap size. */
> 
>    mem = vk_alloc2(&device->alloc, pAllocator, sizeof(*mem), 8,
>-- 
>2.5.0.400.gff86faf
>

Actions: View | Splinter Review

Attachments on bug 100620: 130758 | 130760 | 130761 | 130764 | 130801 | 130802 | 130803 | 130805 | 130985

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.