Attachment 130955 Details for Bug 100707 – 0001-Add-doc-to-discourage-use-of-libinput_device_get_out.patch

[patch] 0001-Add-doc-to-discourage-use-of-libinput_device_get_out.patch

0001-Add-doc-to-discourage-use-of-libinput_device_get_out.patch (text/plain), 1.58 KB, created by Peter Hutterer on 2017-04-20 22:51:11 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Peter Hutterer

Created: 2017-04-20 22:51:11 UTC

Size: 1.58 KB

patch

obsolete

>From 11b8d86fa08b1b83b59dfb6f82f492f76620af06 Mon Sep 17 00:00:00 2001
>From: Peter Hutterer <peter.hutterer@who-t.net>
>Date: Fri, 21 Apr 2017 08:47:31 +1000
>Subject: [PATCH libinput] Add doc to discourage use of
> libinput_device_get_output_name()
>
>This is a leftover from when libinput was part of weston and we could
>interpret properties correctly. Realistically, the only way this could work
>with libinput as external library is if we define precisely what the
>definition of an output is. Practically, it's a lot easier to just throw up
>our hands and leave it all to the caller.
>
>https://bugs.freedesktop.org/show_bug.cgi?id=100707
>
>Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
>---
> src/libinput.h | 7 +++++++
> 1 file changed, 7 insertions(+)
>
>diff --git a/src/libinput.h b/src/libinput.h
>index aa30cfa..48571d8 100644
>--- a/src/libinput.h
>+++ b/src/libinput.h
>@@ -3491,6 +3491,13 @@ libinput_device_get_id_vendor(struct libinput_device *device);
>  * beyond the boundaries of this output. An absolute device has its input
>  * coordinates mapped to the extents of this output.
>  *
>+ * @note <b>Use of this function is discouraged.</b> Its return value is not
>+ * precisely defined and may not be understood by the caller or may be
>+ * insufficient to map the device. Instead, the system configuration should
>+ * set a udev property the caller understands and interprets correctly. The
>+ * caller should then obtain device with libinput_device_get_udev_device()
>+ * and query it for this property.
>+ *
>  * @return The name of the output this device is mapped to, or NULL if no
>  * output is set
>  */
>-- 
>2.9.3
>

Actions: View | Splinter Review

Attachments on bug 100707: 130955

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.