Attachment 131488 Details for Bug 101174 – nice-transmitter: fix nicesrc locking state before unlink

[patch] nice-transmitter: fix nicesrc locking state before unlink

0006-nice-transmitter-fix-nicesrc-locking-state-before-un.patch (text/plain), 1.12 KB, created by Fabrice Bellet on 2017-05-24 20:06:15 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Fabrice Bellet

Created: 2017-05-24 20:06:15 UTC

Size: 1.12 KB

patch

obsolete

>From b314fea7921f74ba1f1e99c4ea00d97f75c80bf3 Mon Sep 17 00:00:00 2001
>From: Fabrice Bellet <fabrice@bellet.info>
>Date: Tue, 23 May 2017 16:18:31 +0200
>Subject: [PATCH] nice-transmitter: fix nicesrc locking state before unlink
>
>A race is possible where the nicesrc state is put back to playing state
>between its null state change, and its removal from the bin. This causes
>complaints from gstreamer, while removing an element still in playing
>state.
>---
> transmitters/nice/fs-nice-transmitter.c | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/transmitters/nice/fs-nice-transmitter.c b/transmitters/nice/fs-nice-transmitter.c
>index 5f30ff5..77ebec4 100644
>--- a/transmitters/nice/fs-nice-transmitter.c
>+++ b/transmitters/nice/fs-nice-transmitter.c
>@@ -754,6 +754,7 @@ fs_nice_transmitter_free_gst_stream (FsNiceTransmitter *self,
>     if (ns->nicesrcs[c])
>     {
>       GstStateChangeReturn ret;
>+      gst_element_set_locked_state (ns->nicesrcs[c], TRUE);
>       ret = gst_element_set_state (ns->nicesrcs[c], GST_STATE_NULL);
>       if (ret != GST_STATE_CHANGE_SUCCESS)
>         GST_ERROR ("Error changing state of nicesrc: %s",
>-- 
>2.9.4
>

Actions: View | Splinter Review

Attachments on bug 101174: 131488

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.