Attachment 131729 Details for Bug 100565 – nice transmitter: Flush source before stopping

[patch] nice transmitter: Flush source before stopping

0001-nice-transmitter-Flush-source-before-stopping.patch (text/plain), 1.15 KB, created by Olivier Crête on 2017-06-05 23:28:11 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Olivier Crête

Created: 2017-06-05 23:28:11 UTC

Size: 1.15 KB

patch

obsolete

>From 77362bb811226d3d689c14fb5af236d3cfc96ec2 Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?Olivier=20Cr=C3=AAte?= <olivier.crete@collabora.com>
>Date: Mon, 5 Jun 2017 19:26:42 -0400
>Subject: [PATCH] nice transmitter: Flush source before stopping
>
>Otherwise we risk a deadlock in some cases
>
>https://bugs.freedesktop.org/show_bug.cgi?id=100565
>---
> transmitters/nice/fs-nice-transmitter.c | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/transmitters/nice/fs-nice-transmitter.c b/transmitters/nice/fs-nice-transmitter.c
>index 51f2371..c84fcae 100644
>--- a/transmitters/nice/fs-nice-transmitter.c
>+++ b/transmitters/nice/fs-nice-transmitter.c
>@@ -756,6 +756,7 @@ fs_nice_transmitter_free_gst_stream (FsNiceTransmitter *self,
>       GstStateChangeReturn ret;
>       if (!gst_bin_remove (GST_BIN (self->priv->gst_src), ns->nicesrcs[c]))
>         GST_ERROR ("Could not remove nicesrc element from transmitter source");
>+      gst_element_send_event (ns->nicesrcs[c], gst_event_new_flush_start ());
>       ret = gst_element_set_state (ns->nicesrcs[c], GST_STATE_NULL);
>       if (ret != GST_STATE_CHANGE_SUCCESS)
>         GST_ERROR ("Error changing state of nicesrc: %s",
>-- 
>2.9.4
>

Actions: View | Splinter Review

Attachments on bug 100565: 130674 | 130675 | 130701 | 131729 | 131920 | 131923 | 131924 | 131951

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.