Attachment 132275 Details for Bug 100242 – likely fix

[patch] likely fix

radeon-winsys-fdo100242.patch (text/plain), 1.45 KB, created by Nicolai Hähnle on 2017-06-27 07:53:41 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nicolai Hähnle

Created: 2017-06-27 07:53:41 UTC

Size: 1.45 KB

patch

obsolete

>commit 5462da85cf9200a7622a699fb8dd0eed00231af9
>Author: Nicolai HÃ¤hnle <nicolai.haehnle@amd.com>
>Date:   Tue Jun 27 09:50:32 2017 +0200
>
>    winsys/radeon: only call pb_slabs_reclaim when slabs are actually used
>    
>    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=100242
>    Fixes: fb827c055cb1 ("winsys/radeon: enable buffer allocation from slabs")
>    Cc: mesa-stable@lists.freedesktop.org
>
>diff --git a/src/gallium/winsys/radeon/drm/radeon_drm_bo.c b/src/gallium/winsys/radeon/drm/radeon_drm_bo.c
>index 9bbf1b3..2700c6f 100644
>--- a/src/gallium/winsys/radeon/drm/radeon_drm_bo.c
>+++ b/src/gallium/winsys/radeon/drm/radeon_drm_bo.c
>@@ -1020,21 +1020,22 @@ no_slab:
> 
>     bo = radeon_bo(pb_cache_reclaim_buffer(&ws->bo_cache, size, alignment,
>                                            usage, pb_cache_bucket));
>     if (bo)
>         return &bo->base;
> 
>     bo = radeon_create_bo(ws, size, alignment, usage, domain, flags,
>                           pb_cache_bucket);
>     if (!bo) {
>         /* Clear the cache and try again. */
>-        pb_slabs_reclaim(&ws->bo_slabs);
>+        if (ws->info.has_virtual_memory)
>+            pb_slabs_reclaim(&ws->bo_slabs);
>         pb_cache_release_all_buffers(&ws->bo_cache);
>         bo = radeon_create_bo(ws, size, alignment, usage, domain, flags,
>                               pb_cache_bucket);
>         if (!bo)
>             return NULL;
>     }
> 
>     bo->u.real.use_reusable_pool = true;
> 
>     mtx_lock(&ws->bo_handles_mutex);

Actions: View | Splinter Review

Attachments on bug 100242: 130277 | 130278 | 130279 | 132275

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.