Attachment 132346 Details for Bug 101567 – spec: Formally deprecate eavesdropping

[patch] spec: Formally deprecate eavesdropping

0002-spec-Formally-deprecate-eavesdropping.patch (text/plain), 5.12 KB, created by Simon McVittie on 2017-06-29 15:36:38 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Simon McVittie

Created: 2017-06-29 15:36:38 UTC

Size: 5.12 KB

patch

obsolete

>From 25287c67b2854e29c4336a9e6e846994d9eb06df Mon Sep 17 00:00:00 2001
>From: Simon McVittie <smcv@collabora.com>
>Date: Thu, 29 Jun 2017 16:32:25 +0100
>Subject: [PATCH 2/3] spec: Formally deprecate eavesdropping
>
>Signed-off-by: Simon McVittie <smcv@collabora.com>
>---
> doc/dbus-specification.xml | 63 ++++++++++++++++++++++++++++++----------------
> 1 file changed, 41 insertions(+), 22 deletions(-)
>
>diff --git a/doc/dbus-specification.xml b/doc/dbus-specification.xml
>index 571f037d..fdc04249 100644
>--- a/doc/dbus-specification.xml
>+++ b/doc/dbus-specification.xml
>@@ -4361,6 +4361,13 @@
>         </para>
> 
>         <para>
>+          Eavesdropping interacts poorly with buses with non-trivial
>+          access control restrictions, and is deprecated. The BecomeMonitor
>+          method (see <xref linkend="bus-messages-become-monitor"/>) provides
>+          a preferable way to monitor buses.
>+        </para>
>+
>+        <para>
>           Eavesdropping is mainly useful for debugging tools, such as
>           the <literal>dbus-monitor</literal> tool in the reference
>           implementation of D-Bus. Tools which eavesdrop on the message bus
>@@ -4377,13 +4384,6 @@
>           adding the same rule with the <literal>eavesdrop</literal> match
>           omitted.
>         </para>
>-
>-        <para>
>-          Eavesdropping interacts poorly with buses with non-trivial
>-          access control restrictions. The
>-          <xref linkend="bus-messages-become-monitor"/> method provides
>-          an alternative way to monitor buses.
>-        </para>
>       </sect3>
> 
>       <sect3 id="message-bus-routing-match-rules">
>@@ -4405,7 +4405,9 @@
>         <para>
>           Match rules can also be used for eavesdropping
>           (see <xref linkend="message-bus-routing-eavesdropping"/>),
>-          if the security policy of the message bus allows it.
>+          if the security policy of the message bus allows it, but this
>+          usage is deprecated in favour of the BecomeMonitor method
>+          (see <xref linkend="bus-messages-become-monitor"/>).
>         </para>
>         <para>
>           Match rules are added using the AddMatch bus method
>@@ -4611,20 +4613,37 @@
>                 <row>
>                   <entry><literal>eavesdrop</literal></entry>
>                   <entry><literal>'true'</literal>, <literal>'false'</literal></entry>
>-                  <entry>Since D-Bus 1.5.6, match rules do not
>-                    match messages which have a <literal>DESTINATION</literal>
>-                    field unless the match rule specifically
>-                    requests this
>-                    (see <xref linkend="message-bus-routing-eavesdropping"/>)
>-                    by specifying <literal>eavesdrop='true'</literal>
>-                    in the match rule.  <literal>eavesdrop='false'</literal>
>-                    restores the default behaviour. Messages are
>-                    delivered to their <literal>DESTINATION</literal>
>-                    regardless of match rules, so this match does not
>-                    affect normal delivery of unicast messages.
>-                    In older versions of D-Bus, this match was not allowed
>-                    in match rules, and all match rules behaved as if
>-                    <literal>eavesdrop='true'</literal> had been used.
>+                  <entry>
>+                    <para>
>+                      Since D-Bus 1.5.6, match rules do not
>+                      match messages which have a <literal>DESTINATION</literal>
>+                      field unless the match rule specifically
>+                      requests this
>+                      (see <xref linkend="message-bus-routing-eavesdropping"/>)
>+                      by specifying <literal>eavesdrop='true'</literal>
>+                      in the match rule.  <literal>eavesdrop='false'</literal>
>+                      restores the default behaviour. Messages are
>+                      delivered to their <literal>DESTINATION</literal>
>+                      regardless of match rules, so this match does not
>+                      affect normal delivery of unicast messages.
>+                      In older versions of D-Bus, this match was not allowed
>+                      in match rules, and all match rules behaved as if
>+                      <literal>eavesdrop='true'</literal> had been used.
>+                    </para>
>+                    <para>
>+                      Use of <literal>eavesdrop='true'</literal> is
>+                      deprecated. Monitors should prefer to use the
>+                      BecomeMonitor method (see
>+                      <xref linkend="bus-messages-become-monitor"/>),
>+                      which was introduced in version 0.26 of the D-Bus
>+                      specification and version 1.9.10 of the reference
>+                      dbus-daemon.
>+                    </para>
>+                    <para>
>+                      Message bus implementations may restrict match rules
>+                      with <literal>eavesdrop='true'</literal> so that they
>+                      can only be added by privileged connections.
>+                    </para>
>                   </entry>
>                 </row>
>               </tbody>
>-- 
>2.13.2
>

Actions: View | Splinter Review

Attachments on bug 101567: 132159 | 132160 | 132164 | 132168 | 132345 | 132346 | 132347

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.