Attachment 133459 Details for Bug 102187 – Patch that fixes the typos

[patch] Patch that fixes the typos

0001-Fix-copy-n-paste-bugs-Qt4-Qt5.patch (text/plain), 2.28 KB, created by oliver.sander on 2017-08-12 14:57:55 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: oliver.sander

Created: 2017-08-12 14:57:55 UTC

Size: 2.28 KB

patch

obsolete

>From 30b856c9b3465a28a03a2d2d2499e3feefd92ebf Mon Sep 17 00:00:00 2001
>From: Oliver Sander <oliver.sander@tu-dresden.de>
>Date: Fri, 11 Aug 2017 22:55:41 +0200
>Subject: [PATCH 1/3] Fix copy'n'paste bugs: Qt4 -> Qt5
>
>---
> qt5/src/ArthurOutputDev.h    | 2 +-
> qt5/src/poppler-annotation.h | 2 +-
> qt5/tests/check_metadata.cpp | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/qt5/src/ArthurOutputDev.h b/qt5/src/ArthurOutputDev.h
>index 61ec9290..20723b70 100644
>--- a/qt5/src/ArthurOutputDev.h
>+++ b/qt5/src/ArthurOutputDev.h
>@@ -48,7 +48,7 @@ class SplashFontEngine;
> struct SplashGlyphBitmap;
> 
> //------------------------------------------------------------------------
>-// ArthurOutputDev - Qt 4 QPainter renderer
>+// ArthurOutputDev - Qt 5 QPainter renderer
> //------------------------------------------------------------------------
> 
> class ArthurOutputDev: public OutputDev {
>diff --git a/qt5/src/poppler-annotation.h b/qt5/src/poppler-annotation.h
>index bf113909..a70cbe4f 100644
>--- a/qt5/src/poppler-annotation.h
>+++ b/qt5/src/poppler-annotation.h
>@@ -154,7 +154,7 @@ class POPPLER_QT5_EXPORT AnnotationUtils
>  * annotations are always positioned as if they were being positioned at the
>  * default page orientation.
>  *
>- * Just like regular annotations, %Poppler Qt4 exposes normalized coordinates
>+ * Just like regular annotations, %Poppler Qt5 exposes normalized coordinates
>  * relative to the page's default orientation. However, behind the scenes, the
>  * coordinate system is different and %Poppler transparently transforms each
>  * shape. If you never call either Annotation::setFlags or
>diff --git a/qt5/tests/check_metadata.cpp b/qt5/tests/check_metadata.cpp
>index 05abbaf4..21262a11 100644
>--- a/qt5/tests/check_metadata.cpp
>+++ b/qt5/tests/check_metadata.cpp
>@@ -33,7 +33,7 @@ void TestMetaData::checkStrings_data()
>     QTest::newRow( "Title" ) << "Title" << "Two pages";
>     QTest::newRow( "Subject" ) << "Subject"
> 			       << "A two page layout for poppler testing";
>-    QTest::newRow( "Keywords" ) << "Keywords" << "Qt4 bindings";
>+    QTest::newRow( "Keywords" ) << "Keywords" << "Qt5 bindings";
>     QTest::newRow( "Creator" ) << "Creator" << "iText: cgpdftops CUPS filter";
>     QTest::newRow( "Producer" ) << "Producer" << "Acrobat Distiller 7.0 for Macintosh";
> }
>-- 
>2.13.2
>

Actions: View | Splinter Review

Attachments on bug 102187: 133459

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.