Attachment 133572 Details for Bug 101921 – Use NULL for GPIO connection ID

[patch] Use NULL for GPIO connection ID

0001-drm-i915-bxt-use-NULL-for-GPIO-connection-ID.patch (text/plain), 1.78 KB, created by Mika Kahola on 2017-08-17 10:27:33 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Mika Kahola

Created: 2017-08-17 10:27:33 UTC

Size: 1.78 KB

patch

obsolete

>From 21fd44ec5fa7571633ada9728c3bef6bf342e160 Mon Sep 17 00:00:00 2001
>From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>Date: Tue, 21 Feb 2017 17:19:02 +0200
>Subject: [PATCH] drm/i915/bxt: use NULL for GPIO connection ID
>
>The commit 213e08ad60ba ("drm/i915/bxt: add bxt dsi gpio element
>support") enables GPIO support for Broxton based platforms.
>
>While using that API we might get into troubles in the future, because
>we can't rely on label "panel" in the driver since vendor firmware might
>provide any GPIO pin there, e.g. "reset", and even mark it in _DSD (in
>which case the request will fail).
>
>To avoid inconsistency and potential issues we have two options:
>a) generate GPIO ACPI mapping table and supply it via
>acpi_dev_add_driver_gpios(), or
>b) just pass NULL as connection ID.
>
>The b) approach is much simplier and would work since the driver relies
>on GPIO indeces only. Moreover, the _CRS fallback mechanism, when
>requesting GPIO, is going to be stricter, and supplying non-NULL
>connection ID when neither _DSD, nor GPIO ACPI mapping is present, will
>make request fail.
>
>Cc: Mika Kahola <mika.kahola@intel.com>
>Cc: Jani Nikula <jani.nikula@intel.com>
>Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>---
> drivers/gpu/drm/i915/intel_dsi_vbt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/gpu/drm/i915/intel_dsi_vbt.c b/drivers/gpu/drm/i915/intel_dsi_vbt.c
>index 0dce779..fe114b6 100644
>--- a/drivers/gpu/drm/i915/intel_dsi_vbt.c
>+++ b/drivers/gpu/drm/i915/intel_dsi_vbt.c
>@@ -306,7 +306,7 @@ static void bxt_exec_gpio(struct drm_i915_private *dev_priv,
> 
> 	if (!gpio_desc) {
> 		gpio_desc = devm_gpiod_get_index(dev_priv->drm.dev,
>-						 "panel", gpio_index,
>+						 NULL, gpio_index,
> 						 value ? GPIOD_OUT_LOW :
> 						 GPIOD_OUT_HIGH);
> 
>-- 
>2.7.4
>

Actions: View | Splinter Review

Attachments on bug 101921: 132980 | 132981 | 133425 | 133572 | 133621 | 133622

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.