Attachment 133612 Details for Bug 102296 – possible fix v2

[patch] possible fix v2

0001-drm-amdgpu-vce-adjust-index-offset-removal.patch (text/plain), 1.17 KB, created by Alex Deucher on 2017-08-18 16:54:14 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Alex Deucher

Created: 2017-08-18 16:54:14 UTC

Size: 1.17 KB

patch

obsolete

>From 65d07408319b3fb69082ce387826880059c7e756 Mon Sep 17 00:00:00 2001
>From: Alex Deucher <alexander.deucher@amd.com>
>Date: Fri, 18 Aug 2017 12:50:34 -0400
>Subject: [PATCH] drm/amdgpu/vce: adjust index offset removal
>
>Remove the index offset before adding the physical address
>to avoid a possible overflow if the offset is very large.
>
>bug: https://bugs.freedesktop.org/show_bug.cgi?id=102296
>Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
>---
> drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c
>index c855366..5981646 100644
>--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c
>+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c
>@@ -581,9 +581,9 @@ static int amdgpu_vce_cs_reloc(struct amdgpu_cs_parser *p, uint32_t ib_idx,
> 		return -EINVAL;
> 	}
> 
>+	addr -= ((uint64_t)size) * ((uint64_t)index);
> 	addr -= mapping->start * AMDGPU_GPU_PAGE_SIZE;
> 	addr += amdgpu_bo_gpu_offset(bo);
>-	addr -= ((uint64_t)size) * ((uint64_t)index);
> 
> 	amdgpu_set_ib_value(p, ib_idx, lo, lower_32_bits(addr));
> 	amdgpu_set_ib_value(p, ib_idx, hi, upper_32_bits(addr));
>-- 
>2.5.5
>

Actions: View | Splinter Review

Attachments on bug 102296: 133608 | 133609 | 133610 | 133611 | 133612 | 133613

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.