Attachment 133895 Details for Bug 102488 – proposed fix

[patch] proposed fix

0001-radv-Preserve-depth-data-when-transitionning-to-htil.patch (text/plain), 1.64 KB, created by xbx on 2017-08-31 08:11:04 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: xbx

Created: 2017-08-31 08:11:04 UTC

Size: 1.64 KB

patch

obsolete

>From f2cec20567b02d332c2b591d5fce388d5fb726b7 Mon Sep 17 00:00:00 2001
>From: Xavier Bouchoux <xavierb@gmail.com>
>Date: Thu, 31 Aug 2017 09:39:05 +0200
>Subject: [RFC PATCH] radv: Preserve depth data when transitioning to htile.
>
>
>---
> src/amd/vulkan/radv_cmd_buffer.c | 13 ++++++++++++-
> 1 file changed, 12 insertions(+), 1 deletion(-)
>
>diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c
>index 1c88717551..5f595efe1e 100644
>--- a/src/amd/vulkan/radv_cmd_buffer.c
>+++ b/src/amd/vulkan/radv_cmd_buffer.c
>@@ -3231,7 +3231,18 @@ static void radv_handle_depth_image_transition(struct radv_cmd_buffer *cmd_buffe
> 		radv_initialize_htile(cmd_buffer, image, range, 0);
> 	} else if (!radv_layout_is_htile_compressed(image, src_layout, src_queue_mask) &&
> 	           radv_layout_is_htile_compressed(image, dst_layout, dst_queue_mask)) {
>-		radv_initialize_htile(cmd_buffer, image, range, 0xffffffff);
>+		VkImageSubresourceRange local_range = *range;
>+		local_range.aspectMask = VK_IMAGE_ASPECT_DEPTH_BIT;
>+		local_range.baseMipLevel = 0;
>+		local_range.levelCount = 1;
>+
>+		cmd_buffer->state.flush_bits |= RADV_CMD_FLAG_FLUSH_AND_INV_DB |
>+		                                RADV_CMD_FLAG_FLUSH_AND_INV_DB_META;
>+
>+		radv_resummarize_depth_image_inplace(cmd_buffer, image, &local_range);
>+
>+		cmd_buffer->state.flush_bits |= RADV_CMD_FLAG_FLUSH_AND_INV_DB |
>+		                                RADV_CMD_FLAG_FLUSH_AND_INV_DB_META;
> 	} else if (radv_layout_is_htile_compressed(image, src_layout, src_queue_mask) &&
> 	           !radv_layout_is_htile_compressed(image, dst_layout, dst_queue_mask)) {
> 		VkImageSubresourceRange local_range = *range;
>-- 
>2.14.1
>

Actions: View | Splinter Review

Attachments on bug 102488: 133895

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.