Attachment 135113 Details for Bug 103487 – Patch

[patch] Patch

0001-lib-Plug-leak.patch (text/plain), 1018 bytes, created by Carlos Garnacho Parro on 2017-10-27 17:12:14 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Carlos Garnacho Parro

Created: 2017-10-27 17:12:14 UTC

Size: 1018 bytes

patch

obsolete

>From 64ecb298ca4ee27985e580de77300590c16e65ee Mon Sep 17 00:00:00 2001
>From: Carlos Garnacho <carlosg@gnome.org>
>Date: Fri, 27 Oct 2017 18:59:04 +0200
>Subject: [PATCH] lib: Plug leak
>
>When updating the user, the previous login_history variant would
>be leaked.
>
>https://bugs.freedesktop.org/show_bug.cgi?id=103487
>---
> src/libaccountsservice/act-user.c | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/src/libaccountsservice/act-user.c b/src/libaccountsservice/act-user.c
>index dbb9b53..300118a 100644
>--- a/src/libaccountsservice/act-user.c
>+++ b/src/libaccountsservice/act-user.c
>@@ -1544,6 +1544,7 @@ _act_user_load_from_user (ActUser    *user,
>         user->login_time = user_to_copy->login_time;
>         g_object_notify (G_OBJECT (user), "login-time");
> 
>+        g_clear_pointer (&user->login_history, g_variant_unref);
>         user->login_history = user_to_copy->login_history ? g_variant_ref (user_to_copy->login_history) : NULL;
>         g_object_notify (G_OBJECT (user), "login-history");
> 
>-- 
>2.14.2
>

Actions: View | Splinter Review

Attachments on bug 103487: 135113

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.