Attachment 135462 Details for Bug 103601 – [02/13] Windows autolaunch: Turn stdout spam into stderr spam

[patch] [02/13] Windows autolaunch: Turn stdout spam into stderr spam

0002-Windows-autolaunch-Turn-stdout-spam-into-stderr-spam.patch (text/plain), 1.41 KB, created by Simon McVittie on 2017-11-14 19:08:59 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Simon McVittie

Created: 2017-11-14 19:08:59 UTC

Size: 1.41 KB

patch

obsolete

>From 899bfab1b03f1c300ba8c40b0187807097d8acfe Mon Sep 17 00:00:00 2001
>From: Simon McVittie <smcv@collabora.com>
>Date: Tue, 14 Nov 2017 14:11:25 +0000
>Subject: [PATCH 02/13] Windows autolaunch: Turn stdout spam into stderr spam
>
>This is still not how warnings and diagnostics should be done
>(the advice should probably be included in the DBusError) but at least
>this way it won't interfere with machine-readable output on stdout.
>
>Signed-off-by: Simon McVittie <smcv@collabora.com>
>---
> dbus/dbus-sysdeps-win.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/dbus/dbus-sysdeps-win.c b/dbus/dbus-sysdeps-win.c
>index 980b431e..90a55a7c 100644
>--- a/dbus/dbus-sysdeps-win.c
>+++ b/dbus/dbus-sysdeps-win.c
>@@ -3082,8 +3082,8 @@ _dbus_get_autolaunch_address (const char *scope, DBusString *address,
>             {
>               dbus_set_error_const (error, DBUS_ERROR_FAILED, "could not find dbus-daemon executable");
>               retval = FALSE;
>-              printf ("please add the path to %s to your PATH environment variable\n", daemon_name);
>-              printf ("or start the daemon manually\n\n");
>+              fprintf (stderr, "please add the path to %s to your PATH environment variable\n", daemon_name);
>+              fprintf (stderr, "or start the daemon manually\n\n");
>               goto out;
>             }
>           _dbus_verbose( "found dbus daemon executable at %s",dbus_module_path);
>-- 
>2.15.0
>

Actions: View | Splinter Review

Attachments on bug 103601: 135460 | 135462 | 135463 | 135464 | 135465 | 135466 | 135467 | 135468 | 135469 | 135470 | 135471 | 135472 | 135473 | 135485

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.