Attachment 135463 Details for Bug 103601 – [03/13] Do not export dbus_internal_do_not_use_run_tests if unused

[patch] [03/13] Do not export dbus_internal_do_not_use_run_tests if unused

0003-Do-not-export-dbus_internal_do_not_use_run_tests-if-.patch (text/plain), 1.33 KB, created by Simon McVittie on 2017-11-14 19:09:13 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Simon McVittie

Created: 2017-11-14 19:09:13 UTC

Size: 1.33 KB

patch

obsolete

>From e32aa4de0ea5067d333e5b5d00f4d184a340b3a5 Mon Sep 17 00:00:00 2001
>From: Simon McVittie <smcv@collabora.com>
>Date: Tue, 14 Nov 2017 15:17:32 +0000
>Subject: [PATCH 03/13] Do not export dbus_internal_do_not_use_run_tests if
> unused
>
>Signed-off-by: Simon McVittie <smcv@collabora.com>
>---
> dbus/dbus-test.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
>diff --git a/dbus/dbus-test.c b/dbus/dbus-test.c
>index 6c0d71f6..312fb78b 100644
>--- a/dbus/dbus-test.c
>+++ b/dbus/dbus-test.c
>@@ -86,8 +86,6 @@ run_data_test (const char             *test_name,
>     }
> }
> 
>-#endif /* DBUS_ENABLE_EMBEDDED_TESTS */
>-
> /**
>  * An exported symbol to be run in order to execute
>  * unit tests. Should not be used by
>@@ -101,7 +99,6 @@ run_data_test (const char             *test_name,
> void
> dbus_internal_do_not_use_run_tests (const char *test_data_dir, const char *specific_test)
> {
>-#ifdef DBUS_ENABLE_EMBEDDED_TESTS
>   if (!_dbus_threads_init_debug ())
>     die ("debug threads init");
>   
>@@ -168,8 +165,6 @@ dbus_internal_do_not_use_run_tests (const char *test_data_dir, const char *speci
>   run_data_test ("auth", specific_test, _dbus_auth_test, test_data_dir);
> 
>   printf ("%s: completed successfully\n", "test-dbus");
>-#else
>-  printf ("Not compiled with unit tests, not running any\n");
>-#endif
> }
> 
>+#endif /* DBUS_ENABLE_EMBEDDED_TESTS */
>-- 
>2.15.0
>

Actions: View | Splinter Review

Attachments on bug 103601: 135460 | 135462 | 135463 | 135464 | 135465 | 135466 | 135467 | 135468 | 135469 | 135470 | 135471 | 135472 | 135473 | 135485

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.