Attachment 135739 Details for Bug 98798 – possible fix

[patch] possible fix

0001-PCI-use-dev_info-rather-than-dev_err-for-rom-validat.patch (text/plain), 1.65 KB, created by Alex Deucher on 2017-11-27 17:18:46 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Alex Deucher

Created: 2017-11-27 17:18:46 UTC

Size: 1.65 KB

patch

obsolete

>From f5d099125cb9f2b0063975475261d8e8898ae313 Mon Sep 17 00:00:00 2001
>From: Alex Deucher <alexander.deucher@amd.com>
>Date: Mon, 27 Nov 2017 10:46:28 -0500
>Subject: [PATCH] PCI: use dev_info rather than dev_err for rom validation
>
>On AMD GPUs, we use several mechanisms to fetch the vbios
>rom depending on the platform.  We try to read the rom
>back via the rom BAR and fall back to other methods in
>some cases.  This leads to spurious error messages
>from the pci rom code which are harmless in our case.
>This leads to bugs being files, etc.  Change these to
>dev_info rather than dev_err to avoid that.
>
>Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
>---
> drivers/pci/rom.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/drivers/pci/rom.c b/drivers/pci/rom.c
>index b6edb187d160..7ab7c6bb17c6 100644
>--- a/drivers/pci/rom.c
>+++ b/drivers/pci/rom.c
>@@ -92,14 +92,14 @@ size_t pci_get_rom_size(struct pci_dev *pdev, void __iomem *rom, size_t size)
> 		void __iomem *pds;
> 		/* Standard PCI ROMs start out with these bytes 55 AA */
> 		if (readw(image) != 0xAA55) {
>-			dev_err(&pdev->dev, "Invalid PCI ROM header signature: expecting 0xaa55, got %#06x\n",
>+			dev_info(&pdev->dev, "Invalid PCI ROM header signature: expecting 0xaa55, got %#06x\n",
> 				readw(image));
> 			break;
> 		}
> 		/* get the PCI data structure and check its "PCIR" signature */
> 		pds = image + readw(image + 24);
> 		if (readl(pds) != 0x52494350) {
>-			dev_err(&pdev->dev, "Invalid PCI ROM data signature: expecting 0x52494350, got %#010x\n",
>+			dev_info(&pdev->dev, "Invalid PCI ROM data signature: expecting 0x52494350, got %#010x\n",
> 				readl(pds));
> 			break;
> 		}
>-- 
>2.13.6
>

Actions: View | Splinter Review

Attachments on bug 98798: 128089 | 131169 | 135739

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.