Attachment 135850 Details for Bug 103987 – Add locking to front-end programming

Add locking to front-end programming

0001-drm-amd-display-add-pipe-locking-before-front-end-pr.patch (text/plain), 2.21 KB, created by Harry Wentland on 2017-12-01 00:34:49 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Harry Wentland

Created: 2017-12-01 00:34:49 UTC

Size: 2.21 KB

patch

obsolete

>From c11203b1488fc1dcf135708e5344e7cc0b88f6b9 Mon Sep 17 00:00:00 2001
>From: Bhawanpreet Lakha <Bhawanpreet.Lakha@amd.com>
>Date: Fri, 24 Nov 2017 17:26:28 -0500
>Subject: [PATCH] drm/amd/display: add pipe locking before front end programing
>
>Add pipe locking/unlocking before we program the front end
>
>Signed-off-by: Bhawanpreet Lakha <Bhawanpreet.Lakha@amd.com>
>Reviewed-by: Harry Wentland <Harry.Wentland@amd.com>
>---
> .../amd/display/dc/dce110/dce110_hw_sequencer.c    | 26 +++++++++++++++++-----
> 1 file changed, 21 insertions(+), 5 deletions(-)
>
>diff --git a/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c b/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c
>index 07ff8d2faf3f..d844fadcd56f 100644
>--- a/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c
>+++ b/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c
>@@ -2866,16 +2866,19 @@ static void dce110_apply_ctx_for_surface(
> 		int num_planes,
> 		struct dc_state *context)
> {
>-	int i, be_idx;
>+	int i;
> 
> 	if (num_planes == 0)
> 		return;
> 
>-	be_idx = -1;
> 	for (i = 0; i < dc->res_pool->pipe_count; i++) {
>-		if (stream == context->res_ctx.pipe_ctx[i].stream) {
>-			be_idx = context->res_ctx.pipe_ctx[i].stream_res.tg->inst;
>-			break;
>+		struct pipe_ctx *pipe_ctx = &context->res_ctx.pipe_ctx[i];
>+		struct pipe_ctx *old_pipe_ctx = &dc->current_state->res_ctx.pipe_ctx[i];
>+
>+		if (stream == pipe_ctx->stream) {
>+			if (!pipe_ctx->top_pipe &&
>+				(pipe_ctx->plane_state || old_pipe_ctx->plane_state))
>+				dc->hwss.pipe_control_lock(dc, pipe_ctx, true);
> 		}
> 	}
> 
>@@ -2895,9 +2898,22 @@ static void dce110_apply_ctx_for_surface(
> 					context->stream_count);
> 
> 		dce110_program_front_end_for_pipe(dc, pipe_ctx);
>+
>+		dc->hwss.update_plane_addr(dc, pipe_ctx);
>+
> 		program_surface_visibility(dc, pipe_ctx);
> 
> 	}
>+
>+	for (i = 0; i < dc->res_pool->pipe_count; i++) {
>+		struct pipe_ctx *pipe_ctx = &context->res_ctx.pipe_ctx[i];
>+		struct pipe_ctx *old_pipe_ctx = &dc->current_state->res_ctx.pipe_ctx[i];
>+
>+		if ((stream == pipe_ctx->stream) &&
>+			(!pipe_ctx->top_pipe) &&
>+			(pipe_ctx->plane_state || old_pipe_ctx->plane_state))
>+			dc->hwss.pipe_control_lock(dc, pipe_ctx, false);
>+	}
> }
> 
> static void dce110_power_down_fe(struct dc *dc, int fe_idx)
>-- 
>2.14.1
>

Actions: View

Attachments on bug 103987: 135826 | 135850

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.