Attachment 13591 Details for Bug 10324 – dix: Always add valuator information if present in GetPointerEvents

[patch] dix: Always add valuator information if present in GetPointerEvents

0001-dix-Always-add-valuator-information-if-present.patch (text/plain), 1.87 KB, created by Magnus Vigerlof on 2008-01-08 13:14:34 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Magnus Vigerlof

Created: 2008-01-08 13:14:34 UTC

Size: 1.87 KB

patch

obsolete

>From 9528bbcb86ae0e96c593c9986bc90f50e515a65f Mon Sep 17 00:00:00 2001
>From: =?utf-8?q?Magnus=20Vigerl=C3=B6f?= <Magnus.Vigerlof@ipbo.se>
>Date: Sun, 16 Dec 2007 14:00:58 +0100
>Subject: [PATCH] dix: Always add valuator information if present in GetPointerEvents
>
>Send valuator information for all pointer events if present, not only
>for MotionEvents and absolute button events.
>---
> dix/getevents.c |    7 ++-----
> 1 files changed, 2 insertions(+), 5 deletions(-)
>
>diff --git a/dix/getevents.c b/dix/getevents.c
>index 12cb950..94cbd15 100644
>--- a/dix/getevents.c
>+++ b/dix/getevents.c
>@@ -525,9 +525,6 @@ GetPointerEvents(xEvent *events, DeviceIntPtr pDev, int type, int buttons,
>     int num_events = 0, final_valuator = 0;
>     CARD32 ms = 0;
>     deviceKeyButtonPointer *kbp = NULL;
>-    /* Thanks to a broken lib, we _always_ have to chase DeviceMotionNotifies
>-     * with DeviceValuators. */
>-    Bool sendValuators = (type == MotionNotify || flags & POINTER_ABSOLUTE);
>     DeviceIntPtr cp = inputInfo.pointer;
>     int x = 0, y = 0;
>     Bool coreOnly = (pDev == inputInfo.pointer);
>@@ -553,7 +550,7 @@ GetPointerEvents(xEvent *events, DeviceIntPtr pDev, int type, int buttons,
>         return 0;
> 
>     /* Do we need to send a DeviceValuator event? */
>-    if (!coreOnly && sendValuators) {
>+    if (!coreOnly && num_valuators) {
>         if ((((num_valuators - 1) / 6) + 1) > MAX_VALUATOR_EVENTS)
>             num_valuators = MAX_VALUATOR_EVENTS * 6;
>         num_events += ((num_valuators - 1) / 6) + 1;
>@@ -684,7 +681,7 @@ GetPointerEvents(xEvent *events, DeviceIntPtr pDev, int type, int buttons,
>         kbp->root_y = y;
> 
>         events++;
>-        if (sendValuators) {
>+        if (num_valuators) {
>             kbp->deviceid |= MORE_EVENTS;
>             clipValuators(pDev, first_valuator, num_valuators, valuators);
>             events = getValuatorEvents(events, pDev, first_valuator,
>-- 
>1.5.2.5
>

Actions: View | Splinter Review

Attachments on bug 10324: 9204 | 13491 | 13591 | 13592 | 13593 | 13624 | 13651 | 13652 | 13653 | 13679

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.