Attachment 136205 Details for Bug 103583 – 0001-Fix-index-out-of-bounds-in-PSTokenizer.patch

[patch] 0001-Fix-index-out-of-bounds-in-PSTokenizer.patch

0001-Fix-index-out-of-bounds-in-PSTokenizer.patch (text/plain), 1.41 KB, created by LE GARREC Vincent on 2017-12-15 19:27:34 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: LE GARREC Vincent

Created: 2017-12-15 19:27:34 UTC

Size: 1.41 KB

patch

obsolete

>From 0accd84bfb94d43a9e3832f452100ede4bdabdfb Mon Sep 17 00:00:00 2001
>From: bansan85 <legarrec.vincent@gmail.com>
>Date: Fri, 15 Dec 2017 20:18:25 +0100
>Subject: [PATCH] Fix index out of bounds in PSTokenizer
>
>Bug #103583
>---
> poppler/PSTokenizer.cc | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
>diff --git a/poppler/PSTokenizer.cc b/poppler/PSTokenizer.cc
>index 05127f0d..c8859a87 100644
>--- a/poppler/PSTokenizer.cc
>+++ b/poppler/PSTokenizer.cc
>@@ -84,7 +84,7 @@ GBool PSTokenizer::getToken(char *buf, int size, int *length) {
>       }
>     } else if (c == '%') {
>       comment = gTrue;
>-    } else if (specialChars[c] != 1) {
>+    } else if (specialChars[static_cast<unsigned char>(c)] != 1) {
>       break;
>     }
>   }
>@@ -113,7 +113,7 @@ GBool PSTokenizer::getToken(char *buf, int size, int *length) {
>   } else if (c == '<') {
>     while ((c = lookChar()) != EOF) {
>       consumeChar();
>-      if (i < size && specialChars[c] != 1) {
>+      if (i < size && specialChars[static_cast<unsigned char>(c)] != 1) {
> 	buf[i++] = c;
>       }
>       if (c == '>') {
>@@ -121,7 +121,8 @@ GBool PSTokenizer::getToken(char *buf, int size, int *length) {
>       }
>     }
>   } else if (c != '[' && c != ']') {
>-    while ((c = lookChar()) != EOF && !specialChars[c]) {
>+    while ((c = lookChar()) != EOF &&
>+    !specialChars[static_cast<unsigned char>(c)]) {
>       consumeChar();
>       if (i < size) {
> 	buf[i++] = c;
>-- 
>2.15.1
>

Actions: View | Splinter Review

Attachments on bug 103583: 135249 | 135941 | 136205 | 136206

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.