Attachment 136629 Details for Bug 101649 – v4-drm-i915-Ignore-TMDS-clock-limit.patch

[patch] v4-drm-i915-Ignore-TMDS-clock-limit.patch

v4-drm-i915-Ignore-TMDS-clock-limit.patch (text/plain), 2.49 KB, created by Abdiel Janulgue on 2018-01-09 09:18:55 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Abdiel Janulgue

Created: 2018-01-09 09:18:55 UTC

Size: 2.49 KB

patch

obsolete

>From 0167128e0233bd1f58a0219dd360356062449712 Mon Sep 17 00:00:00 2001
>From: Abdiel Janulgue <abdiel.janulgue@linux.intel.com>
>Date: Thu, 14 Dec 2017 09:03:37 +0200
>Subject: [PATCH] drm/i915: Ignore TMDS clock limit for DP++ when EDID override
> is set
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>4K modes testing by using dummy EDID data has never been working
>properly on boxes with DP++ (dual-mode) adaptors. The reason for
>this is that those modes got pruned during hdmi mode validation.
>intel_hdmi_mode_valid returns CLOCK_HIGH because the pixel clock
>reported by the 4k mode is higher than dual port TMDS clock limit.
>
>However 4k injection does work properly on machines that don't have
>DP++ adapters because the mode is never validated against the DP++
>TMDS clock limit.
>
>v2: Don't detect the DP++ limits when we're testing using overridden
>    EDIDs. Make sure to check for the override condition after
>    respecting the value of drm_dp_dual_mode_detect (Jani Nikula).
>
>v3: For testing. Add debug that let us know override_edid is set.
>
>v4: Test connector override status
>
>Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101649
>Cc: Ville SyrjÃ¤lÃ¤ <ville.syrjala@linux.intel.com>
>Cc: Jani Nikula <jani.nikula@intel.com>
>Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
>Signed-off-by: Abdiel Janulgue <abdiel.janulgue@linux.intel.com>
>---
> drivers/gpu/drm/i915/intel_hdmi.c | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
>diff --git a/drivers/gpu/drm/i915/intel_hdmi.c b/drivers/gpu/drm/i915/intel_hdmi.c
>index bced7b9..25639ad 100644
>--- a/drivers/gpu/drm/i915/intel_hdmi.c
>+++ b/drivers/gpu/drm/i915/intel_hdmi.c
>@@ -1567,12 +1567,17 @@ intel_hdmi_dp_dual_mode_detect(struct drm_connector *connector, bool has_edid)
> 	 * there's nothing connected to the port.
> 	 */
> 	if (type == DRM_DP_DUAL_MODE_UNKNOWN) {
>-		if (has_edid &&
>+		/* An overridden EDID imply that we want this port for testing.
>+		 * Make sure not to set limits for that port.
>+		 */
>+		if (has_edid && !connector->override_edid &&
> 		    intel_bios_is_port_dp_dual_mode(dev_priv, port)) {
>-			DRM_DEBUG_KMS("Assuming DP dual mode adaptor presence based on VBT\n");
>+			DRM_DEBUG_KMS("Assuming DP dual mode adaptor presence based on VBT. EDID Override Status: %d\n", connector->override_edid);
> 			type = DRM_DP_DUAL_MODE_TYPE1_DVI;
> 		} else {
> 			type = DRM_DP_DUAL_MODE_NONE;
>+			if (connector->override_edid)
>+				DRM_DEBUG_KMS("Override EDID set. Not setting max TMDS clock\n");
> 		}
> 	}
> 
>-- 
>2.7.4
>

Actions: View | Splinter Review

Attachments on bug 101649: 132348 | 132349 | 132956 | 132957 | 136440 | 136487 | 136549 | 136629 | 136658

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.