Attachment 136655 Details for Bug 104564 – Expose the automatic login users as a daemon property.

[patch] Expose the automatic login users as a daemon property.

0001-Expose-the-automatic-login-users-as-a-daemon-propert.patch (text/plain), 2.55 KB, created by Robert Ancell on 2018-01-10 20:21:25 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Robert Ancell

Created: 2018-01-10 20:21:25 UTC

Size: 2.55 KB

patch

obsolete

>From ef5b861e793667fc4be086851102e088ead302cf Mon Sep 17 00:00:00 2001
>From: Robert Ancell <robert.ancell@canonical.com>
>Date: Thu, 21 Dec 2017 14:59:25 +1300
>Subject: [PATCH] Expose the automatic login users as a daemon property.
>
>This stops us having to iterate across each user to find which users are
>configured for automatic login.
>
>Currently we only support 0 or 1 automatic login user, but this allows
>us to support multiple in the future if required. Since D-Bus doesn't have
>nullable types [1] this also makes it easier to support the 0 case.
>
>https://bugs.freedesktop.org/show_bug.cgi?id=104564
>
>[1] https://bugs.freedesktop.org/show_bug.cgi?id=27857
>---
> data/org.freedesktop.Accounts.xml | 10 ++++++++++
> src/daemon.c                      |  7 +++++++
> 2 files changed, 17 insertions(+)
>
>diff --git a/data/org.freedesktop.Accounts.xml b/data/org.freedesktop.Accounts.xml
>index 70e9586..4612c5d 100644
>--- a/data/org.freedesktop.Accounts.xml
>+++ b/data/org.freedesktop.Accounts.xml
>@@ -243,5 +243,15 @@
>      </doc:doc>
>    </property>
> 
>+   <property name="AutomaticLoginUsers" type="ao" access="read">
>+     <doc:doc>
>+       <doc:description>
>+         <doc:para>
>+           Users to automatically log in as
>+         </doc:para>
>+       </doc:description>
>+     </doc:doc>
>+   </property>
>+
>   </interface>
> </node>
>diff --git a/src/daemon.c b/src/daemon.c
>index 3d588ac..9ec153a 100644
>--- a/src/daemon.c
>+++ b/src/daemon.c
>@@ -551,6 +551,7 @@ static gboolean load_autologin (Daemon    *daemon,
> static gboolean
> reload_autologin_timeout (Daemon *daemon)
> {
>+        AccountsAccounts *accounts = ACCOUNTS_ACCOUNTS (daemon);
>         gboolean enabled;
>         g_autofree gchar *name = NULL;
>         g_autoptr(GError) error = NULL;
>@@ -573,7 +574,12 @@ reload_autologin_timeout (Daemon *daemon)
>         }
> 
>         if (enabled) {
>+                const gchar *users[2];
>+
>                 g_debug ("automatic login is enabled for '%s'", name);
>+                users[0] = user_get_object_path (user);
>+                users[1] = NULL;
>+                accounts_accounts_set_automatic_login_users (accounts, users);
>                 if (daemon->priv->autologin != user) {
>                         g_object_set (user, "automatic-login", TRUE, NULL);
>                         daemon->priv->autologin = g_object_ref (user);
>@@ -582,6 +588,7 @@ reload_autologin_timeout (Daemon *daemon)
>         }
>         else {
>                 g_debug ("automatic login is disabled");
>+                accounts_accounts_set_automatic_login_users (accounts, NULL);
>         }
> 
>         return FALSE;
>-- 
>2.15.1
>

Actions: View | Splinter Review

Attachments on bug 104564: 136639 | 136655

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.