Attachment 136694 Details for Bug 104610 – test/containers: Don't require type, name in GetConnectionCredentials

[patch] test/containers: Don't require type, name in GetConnectionCredentials

0002-test-containers-Don-t-require-type-name-in-GetConnec.patch (text/plain), 1.55 KB, created by Simon McVittie on 2018-01-12 20:02:40 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Simon McVittie

Created: 2018-01-12 20:02:40 UTC

Size: 1.55 KB

patch

obsolete

>From 23bfc708aa950915c85a774322d4e43a763152ba Mon Sep 17 00:00:00 2001
>From: Simon McVittie <smcv@collabora.com>
>Date: Wed, 10 Jan 2018 15:00:41 +0000
>Subject: [PATCH 2/6] test/containers: Don't require type, name in
> GetConnectionCredentials
>
>On the session bus, the container type and name might be
>uncontroversial, but on the system bus, it's questionable how far
>they can be trusted: they're supplied by the initiator of the
>per-container server, so we only have their word for it.
>
>Signed-off-by: Simon McVittie <smcv@collabora.com>
>---
> test/containers.c | 8 --------
> 1 file changed, 8 deletions(-)
>
>diff --git a/test/containers.c b/test/containers.c
>index b706bdd1..92e93ae6 100644
>--- a/test/containers.c
>+++ b/test/containers.c
>@@ -509,14 +509,6 @@ test_metadata (Fixture *f,
>                                         DBUS_INTERFACE_CONTAINERS1 ".Instance",
>                                         "&o", &path_from_query));
>   g_assert_cmpstr (path_from_query, ==, f->instance_path);
>-  g_assert_true (g_variant_dict_lookup (&dict,
>-                                        DBUS_INTERFACE_CONTAINERS1 ".Type",
>-                                        "&s", &type));
>-  g_assert_cmpstr (type, ==, "org.example.Springwatch");
>-  g_assert_true (g_variant_dict_lookup (&dict,
>-                                        DBUS_INTERFACE_CONTAINERS1 ".Name",
>-                                        "&s", &name));
>-  g_assert_cmpstr (name, ==, "");
>   g_variant_dict_clear (&dict);
>   g_clear_pointer (&asv, g_variant_unref);
>   g_clear_pointer (&tuple, g_variant_unref);
>-- 
>2.15.1
>

Actions: View | Splinter Review

Attachments on bug 104610: 136694 | 136695 | 136696 | 136697 | 136698 | 136725

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.