Attachment 136725 Details for Bug 104610 – [v2] spec: Add initiator credentials to container instance information

[patch] [v2] spec: Add initiator credentials to container instance information

0001-spec-Add-initiator-credentials-to-container-instance.patch (text/plain), 7.18 KB, created by Simon McVittie on 2018-01-15 12:44:13 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Simon McVittie

Created: 2018-01-15 12:44:13 UTC

Size: 7.18 KB

patch

obsolete

>From 8bc40995f8444d89ab8208337ba8581958d366eb Mon Sep 17 00:00:00 2001
>From: Simon McVittie <smcv@collabora.com>
>Date: Thu, 11 Jan 2018 18:18:07 +0000
>Subject: [PATCH] spec: Add initiator credentials to container instance
> information
>
>Signed-off-by: Simon McVittie <smcv@collabora.com>
>---
> doc/dbus-specification.xml | 68 +++++++++++++++++++++++++++++++++++++++-------
> 1 file changed, 58 insertions(+), 10 deletions(-)
>
>diff --git a/doc/dbus-specification.xml b/doc/dbus-specification.xml
>index d7d2b629..373af74a 100644
>--- a/doc/dbus-specification.xml
>+++ b/doc/dbus-specification.xml
>@@ -7241,6 +7241,7 @@
>           <programlisting>
>             GetConnectionInstance (in STRING bus_name,
>                                    out OBJECT_PATH container_instance,
>+                                   out DICT&lt;STRING,VARIANT&gt; initiator,
>                                    out STRING container_type,
>                                    out STRING container_name,
>                                    out DICT&lt;STRING,VARIANT&gt; metadata)
>@@ -7276,31 +7277,54 @@
>                 </row>
>                 <row>
>                   <entry>2</entry>
>+                  <entry>DICT&lt;STRING,VARIANT&gt;</entry>
>+                  <entry>
>+                    The credentials of the connection that called the
>+                    <literal>AddServer</literal> method, encoded in the
>+                    same way as the result of the
>+                    <link linkend="bus-messages-get-connection-credentials"
>+                      >GetConnectionCredentials</link> method.
>+                    Unlike the container type, name and metadata, these
>+                    are supplied by the message bus, and can be trusted to
>+                    the same extent as GetConnectionCredentials.
>+                  </entry>
>+                </row>
>+                <row>
>+                  <entry>3</entry>
>                   <entry>STRING</entry>
>                   <entry>
>                     Reversed domain name identifying a container
>                     manager or container technology, as passed to the
>                     <literal>AddServer</literal> method, such as
>                     <literal>org.flatpak</literal> or
>-                    <literal>io.snapcraft</literal>.
>+                    <literal>io.snapcraft</literal>. This information
>+                    was provided by the initiator of the per-container
>+                    server, and should only be trusted by other processes
>+                    if they trust that initiator.
>                   </entry>
>                 </row>
>                 <row>
>-                  <entry>3</entry>
>+                  <entry>4</entry>
>                   <entry>STRING</entry>
>                   <entry>
>                     Some unique identifier for an application or container,
>                     whose meaning is defined by the maintainers of the
>-                    container type.
>+                    container type. Like the container type, this information
>+                    was provided by the initiator of the per-container
>+                    server, and should only be trusted by other processes
>+                    if they trust that initiator.
>                   </entry>
>                 </row>
>                 <row>
>-                  <entry>4</entry>
>+                  <entry>5</entry>
>                   <entry>DICT&lt;STRING,VARIANT&gt;</entry>
>                   <entry>
>                     Metadata describing the application or container, with the
>                     keys and values defined by the maintainers of the container
>-                    type.
>+                    type. Like the container type, this information
>+                    was provided by the initiator of the per-container
>+                    server, and should only be trusted by other processes
>+                    if they trust that initiator.
>                   </entry>
>                 </row>
>               </tbody>
>@@ -7326,6 +7350,7 @@
>           As a method:
>           <programlisting>
>             GetInstanceInfo (in OBJECT_PATH container_instance,
>+                             out DICT&lt;STRING,VARIANT&gt; initiator,
>                              out STRING container_type,
>                              out STRING container_name,
>                              out DICT&lt;STRING,VARIANT&gt; metadata)
>@@ -7352,31 +7377,54 @@
>                 </row>
>                 <row>
>                   <entry>1</entry>
>+                  <entry>DICT&lt;STRING,VARIANT&gt;</entry>
>+                  <entry>
>+                    The credentials of the connection that called the
>+                    <literal>AddServer</literal> method, encoded in the
>+                    same way as the result of the
>+                    <link linkend="bus-messages-get-connection-credentials"
>+                      >GetConnectionCredentials</link> method.
>+                    Unlike the container type, name and metadata, these
>+                    are supplied by the message bus, and can be trusted to
>+                    the same extent as GetConnectionCredentials.
>+                  </entry>
>+                </row>
>+                <row>
>+                  <entry>2</entry>
>                   <entry>STRING</entry>
>                   <entry>
>                     Reversed domain name identifying a container
>                     manager or container technology, as passed to the
>                     <literal>AddServer</literal> method, such as
>                     <literal>org.flatpak</literal> or
>-                    <literal>io.snapcraft</literal>.
>+                    <literal>io.snapcraft</literal>. This information
>+                    was provided by the initiator of the per-container
>+                    server, and should only be trusted by other processes
>+                    if they trust that initiator.
>                   </entry>
>                 </row>
>                 <row>
>-                  <entry>2</entry>
>+                  <entry>3</entry>
>                   <entry>STRING</entry>
>                   <entry>
>                     Some unique identifier for an application or container,
>                     whose meaning is defined by the maintainers of the
>-                    container type.
>+                    container type. Like the container type, this information
>+                    was provided by the initiator of the per-container
>+                    server, and should only be trusted by other processes
>+                    if they trust that initiator.
>                   </entry>
>                 </row>
>                 <row>
>-                  <entry>3</entry>
>+                  <entry>4</entry>
>                   <entry>DICT&lt;STRING,VARIANT&gt;</entry>
>                   <entry>
>                     Metadata describing the application or container, with the
>                     keys and values defined by the maintainers of the container
>-                    type.
>+                    type. Like the container type, this information
>+                    was provided by the initiator of the per-container
>+                    server, and should only be trusted by other processes
>+                    if they trust that initiator.
>                   </entry>
>                 </row>
>               </tbody>
>-- 
>2.15.1
>

Actions: View | Splinter Review

Attachments on bug 104610: 136694 | 136695 | 136696 | 136697 | 136698 | 136725

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.