Attachment 136782 Details for Bug 104660 – Fix for dual-link DVI modes

[patch] Fix for dual-link DVI modes

0001-drm-amd-display-Call-update_stream_signal-directly-f.patch (text/plain), 3.04 KB, created by Harry Wentland on 2018-01-16 18:54:14 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Harry Wentland

Created: 2018-01-16 18:54:14 UTC

Size: 3.04 KB

patch

obsolete

>From 912b3c6f92aec39158b34afe3f188f1774b55346 Mon Sep 17 00:00:00 2001
>From: Harry Wentland <harry.wentland@amd.com>
>Date: Mon, 18 Dec 2017 12:01:30 -0500
>Subject: [PATCH] drm/amd/display: Call update_stream_signal directly from
> amdgpu_dm
>
>There's no good place in DC to cover all place where stream signal should
>be updated. update_stream_signal depends on timing which comes from DM.
>
>Signed-off-by: Harry Wentland <harry.wentland@amd.com>
>---
> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 10 +++-------
> drivers/gpu/drm/amd/display/dc/core/dc_stream.c   |  2 +-
> drivers/gpu/drm/amd/display/dc/dc_stream.h        |  2 ++
> 3 files changed, 6 insertions(+), 8 deletions(-)
>
>diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
>index 5a70682c30aa..496d17d2439e 100644
>--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
>+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
>@@ -2444,6 +2444,7 @@ create_stream_for_sink(struct amdgpu_dm_connector *aconnector,
> 				dm_state ? (dm_state->scaling != RMX_OFF) : false);
> 	}
> 
>+	drm_mode_set_crtcinfo(&mode, 0);
> 	fill_stream_properties_from_drm_display_mode(stream,
> 			&mode, &aconnector->base);
> 	update_stream_scaling_settings(&mode, dm_state, stream);
>@@ -2453,6 +2454,8 @@ create_stream_for_sink(struct amdgpu_dm_connector *aconnector,
> 		drm_connector,
> 		aconnector->dc_sink);
> 
>+	update_stream_signal(stream);
>+
> 	return stream;
> }
> 
>@@ -2857,13 +2860,6 @@ int amdgpu_dm_connector_mode_valid(struct drm_connector *connector,
> 		goto fail;
> 	}
> 
>-	drm_mode_set_crtcinfo(mode, 0);
>-	fill_stream_properties_from_drm_display_mode(stream, mode, connector);
>-
>-	stream->src.width = mode->hdisplay;
>-	stream->src.height = mode->vdisplay;
>-	stream->dst = stream->src;
>-
> 	dc_result = dc_validate_stream(adev->dm.dc, stream);
> 
> 	if (dc_result == DC_OK)
>diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_stream.c b/drivers/gpu/drm/amd/display/dc/core/dc_stream.c
>index 3cbdd8cacd37..c3b198836d1d 100644
>--- a/drivers/gpu/drm/amd/display/dc/core/dc_stream.c
>+++ b/drivers/gpu/drm/amd/display/dc/core/dc_stream.c
>@@ -33,7 +33,7 @@
> /*******************************************************************************
>  * Private functions
>  ******************************************************************************/
>-static void update_stream_signal(struct dc_stream_state *stream)
>+void update_stream_signal(struct dc_stream_state *stream)
> {
> 
> 	struct dc_sink *dc_sink = stream->sink;
>diff --git a/drivers/gpu/drm/amd/display/dc/dc_stream.h b/drivers/gpu/drm/amd/display/dc/dc_stream.h
>index be3eb57f3c33..7c3a5775fe1b 100644
>--- a/drivers/gpu/drm/amd/display/dc/dc_stream.h
>+++ b/drivers/gpu/drm/amd/display/dc/dc_stream.h
>@@ -237,6 +237,8 @@ enum surface_update_type dc_check_update_surfaces_for_stream(
>  */
> struct dc_stream_state *dc_create_stream_for_sink(struct dc_sink *dc_sink);
> 
>+void update_stream_signal(struct dc_stream_state *stream);
>+
> void dc_stream_retain(struct dc_stream_state *dc_stream);
> void dc_stream_release(struct dc_stream_state *dc_stream);
> 
>-- 
>2.14.1
>

Actions: View | Splinter Review

Attachments on bug 104660: 136779 | 136780 | 136782

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.