Attachment 137166 Details for Bug 104919 – Possible fix

[patch] Possible fix

0001-drm-amdgpu-sync-the-VM-PD-PT-before-clearing-it.patch (text/plain), 1.15 KB, created by Christian König on 2018-02-04 18:38:55 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Christian König

Created: 2018-02-04 18:38:55 UTC

Size: 1.15 KB

patch

obsolete

>From 1205cfb6ac282f653b65fbd49ff13a6f504bb3f1 Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?Christian=20K=C3=B6nig?= <christian.koenig@amd.com>
>Date: Sun, 4 Feb 2018 19:36:52 +0100
>Subject: [PATCH] drm/amdgpu: sync the VM PD/PT before clearing it
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>Otherwise we might overwrite stuff which is still in use.
>
>Signed-off-by: Christian KÃ¶nig <christian.koenig@amd.com>
>---
> drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
>diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
>index 9833090faeca..0fca8895c289 100644
>--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
>+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
>@@ -329,6 +329,11 @@ static int amdgpu_vm_clear_bo(struct amdgpu_device *adev,
> 	amdgpu_ring_pad_ib(ring, &job->ibs[0]);
> 
> 	WARN_ON(job->ibs[0].length_dw > 64);
>+	r = amdgpu_sync_resv(adev, &job->sync, bo->tbo.resv,
>+			     AMDGPU_FENCE_OWNER_UNDEFINED, false);
>+	if (r)
>+		goto error_free;
>+
> 	r = amdgpu_job_submit(job, ring, &vm->entity,
> 			      AMDGPU_FENCE_OWNER_UNDEFINED, &fence);
> 	if (r)
>-- 
>2.14.1
>

Actions: View | Splinter Review

Attachments on bug 104919: 137138 | 137166

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.