Attachment 137476 Details for Bug 102820 – drm/amd/display: Default HDMI6G support to true. Log VBIOS table error.

[patch] drm/amd/display: Default HDMI6G support to true. Log VBIOS table error.

0001-drm-amd-display-Default-HDMI6G-support-to-true.-Log-.patch (text/plain), 2.35 KB, created by Harry Wentland on 2018-02-20 18:48:25 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Harry Wentland

Created: 2018-02-20 18:48:25 UTC

Size: 2.35 KB

patch

obsolete

>From f7644b52adb5685570bcd69d5fe32c1b9969af67 Mon Sep 17 00:00:00 2001
>From: Harry Wentland <harry.wentland@amd.com>
>Date: Tue, 20 Feb 2018 13:36:23 -0500
>Subject: [PATCH] drm/amd/display: Default HDMI6G support to true. Log VBIOS
> table error.
>
>There have been many reports of Ellesmere and Baffin systems not being
>able to drive HDMI 4k60 due to the fact that we check the HDMI_6GB_EN
>bit from VBIOS table. Windows seems to not have this issue.
>
>I haven't been able to repro but this change covers the only thing that
>I see different between the two OSes and hopefully helps us figure out
>what's going on here.
>
>Change-Id: I5604fa964ecb9f5940cae16ac17d8ba13d10231a
>Signed-off-by: Harry Wentland <harry.wentland@amd.com>
>---
> drivers/gpu/drm/amd/display/dc/dce/dce_link_encoder.c | 16 +++++++++++++---
> 1 file changed, 13 insertions(+), 3 deletions(-)
>
>diff --git a/drivers/gpu/drm/amd/display/dc/dce/dce_link_encoder.c b/drivers/gpu/drm/amd/display/dc/dce/dce_link_encoder.c
>index 11f50588b3f4..4a0a4116e147 100644
>--- a/drivers/gpu/drm/amd/display/dc/dce/dce_link_encoder.c
>+++ b/drivers/gpu/drm/amd/display/dc/dce/dce_link_encoder.c
>@@ -676,6 +676,7 @@ void dce110_link_encoder_construct(
> {
> 	struct bp_encoder_cap_info bp_cap_info = {0};
> 	const struct dc_vbios_funcs *bp_funcs = init_data->ctx->dc_bios->funcs;
>+	enum bp_result result = BP_RESULT_OK;
> 
> 	enc110->base.funcs = &dce110_lnk_enc_funcs;
> 	enc110->base.ctx = init_data->ctx;
>@@ -750,15 +751,24 @@ void dce110_link_encoder_construct(
> 		enc110->base.preferred_engine = ENGINE_ID_UNKNOWN;
> 	}
> 
>+	/* default to one to mirror Windows behavior */
>+	enc110->base.features.flags.bits.HDMI_6GB_EN = 1;
>+
>+	result = bp_funcs->get_encoder_cap_info(enc110->base.ctx->dc_bios,
>+						enc110->base.id, &bp_cap_info);
>+
> 	/* Override features with DCE-specific values */
>-	if (BP_RESULT_OK == bp_funcs->get_encoder_cap_info(
>-			enc110->base.ctx->dc_bios, enc110->base.id,
>-			&bp_cap_info)) {
>+	if (BP_RESULT_OK == result) {
> 		enc110->base.features.flags.bits.IS_HBR2_CAPABLE =
> 				bp_cap_info.DP_HBR2_EN;
> 		enc110->base.features.flags.bits.IS_HBR3_CAPABLE =
> 				bp_cap_info.DP_HBR3_EN;
> 		enc110->base.features.flags.bits.HDMI_6GB_EN = bp_cap_info.HDMI_6GB_EN;
>+	} else {
>+		dm_logger_write(ctx->logger, LOG_WARNING,
>+				"%s: Failed to get encoder_cap_info from VBIOS with error code %d!\n",
>+				__func__,
>+				result);
> 	}
> }
> 
>-- 
>2.14.1
>

Actions: View | Splinter Review

Attachments on bug 102820: 134299 | 134300 | 137476 | 137487

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.