Attachment 137958 Details for Bug 105415 – proposed patch

[patch] proposed patch

foo.diff (text/plain), 1.14 KB, created by Akira TAGOH on 2018-03-10 08:27:39 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Akira TAGOH

Created: 2018-03-10 08:27:39 UTC

Size: 1.14 KB

patch

obsolete

>diff --git a/src/fcname.c b/src/fcname.c
>index 79e413e..2172d70 100644
>--- a/src/fcname.c
>+++ b/src/fcname.c
>@@ -330,13 +330,36 @@ FcNameConvert (FcType type, FcChar8 *string)
>     case FcTypeRange:
> 	if (sscanf ((char *) string, "[%lg %lg]", &b, &e) != 2)
> 	{
>-	    v.u.d = strtod ((char *) string, &p);
>-	    if (p != NULL && p[0] != 0)
>+	    char *sc, *ec;
>+	    size_t len = strlen ((const char *) string);
>+	    int si, ei;
>+
>+	    sc = malloc (len);
>+	    ec = malloc (len);
>+	    if (sc && ec && sscanf ((char *) string, "[%s %[^]]]", sc, ec) == 2)
> 	    {
>-		v.type = FcTypeVoid;
>-		break;
>+		if (FcNameConstant ((const FcChar8 *) sc, &si) && FcNameConstant ((const FcChar8 *) ec, &ei))
>+		    v.u.r =  FcRangeCreateDouble (si, ei);
>+		else
>+		    goto bail1;
>+	    }
>+	    else
>+	    {
>+	    bail1:
>+		v.type = FcTypeDouble;
>+		if (FcNameConstant (string, &si))
>+		{
>+		    v.u.d = (double) si;
>+		} else {
>+		    v.u.d = strtod ((char *) string, &p);
>+		    if (p != NULL && p[0] != 0)
>+			v.type = FcTypeVoid;
>+		}
> 	    }
>-	    v.type = FcTypeDouble;
>+	    if (sc)
>+		free (sc);
>+	    if (ec)
>+		free (ec);
> 	}
> 	else
> 	    v.u.r = FcRangeCreateDouble (b, e);

Actions: View | Splinter Review

Attachments on bug 105415: 137956 | 137957 | 137958

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.