Attachment 138001 Details for Bug 105429 – lib: fix compilation warning

[patch] lib: fix compilation warning

lib-fix-compilation-warning.patch (text/plain), 2.12 KB, created by Mark Harfouche on 2018-03-11 20:56:18 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Mark Harfouche

Created: 2018-03-11 20:56:18 UTC

Size: 2.12 KB

patch

obsolete

>From 101f1b0dbaf792cd16131d60e98202ff1d7d6066 Mon Sep 17 00:00:00 2001
>From: Mark Harfouche <mark.harfouche@gmail.com>
>Date: Sun, 11 Mar 2018 13:38:56 -0700
>Subject: [PATCH] lib: fix compilation warning
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>```
>nbis/mindtct/morph.c:152:4: warning: this âifâ clause does not guard... [-Wmisleading-indentation]
>nbis/mindtct/morph.c:176:4: warning: this âifâ clause does not guard... [-Wmisleading-indentation]
>nbis/mindtct/morph.c:200:4: warning: this âifâ clause does not guard... [-Wmisleading-indentation]
>nbis/mindtct/morph.c:222:4: warning: this âifâ clause does not guard... [-Wmisleading-indentation]
>```
>
>https://bugs.freedesktop.org/show_bug.cgi?id=105429
>---
> libfprint/nbis/mindtct/morph.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
>diff --git a/libfprint/nbis/mindtct/morph.c b/libfprint/nbis/mindtct/morph.c
>index b6be74f..d4ec85f 100644
>--- a/libfprint/nbis/mindtct/morph.c
>+++ b/libfprint/nbis/mindtct/morph.c
>@@ -151,7 +151,7 @@ char get_south8_2(char *ptr, const int row, const int iw, const int ih,
> {
>    if (row >= ih-1) /* catch case where image is undefined southwards   */
>       return failcode; /* use plane geometry and return code.           */
>-
>+   else
>       return *(ptr+iw);
> }
> 
>@@ -175,7 +175,7 @@ char get_north8_2(char *ptr, const int row, const int iw,
> {
>    if (row < 1)     /* catch case where image is undefined northwards   */
>       return failcode; /* use plane geometry and return code.           */
>-
>+   else
>       return *(ptr-iw);
> }
> 
>@@ -199,7 +199,7 @@ char get_east8_2(char *ptr, const int col, const int iw,
> {
>    if (col >= iw-1) /* catch case where image is undefined eastwards    */
>       return failcode; /* use plane geometry and return code.           */
>-
>+   else
>       return *(ptr+ 1);
> }
> 
>@@ -221,6 +221,6 @@ char get_west8_2(char *ptr, const int col, const int failcode)
> {
>    if (col < 1)     /* catch case where image is undefined westwards     */
>       return failcode; /* use plane geometry and return code.            */
>-
>+   else
>       return *(ptr- 1);
> }
>-- 
>2.14.3

Actions: View | Splinter Review

Attachments on bug 105429: 137970 | 137992 | 137993 | 137994 | 137995 | 137996 | 137997 | 137998 | 137999 | 138000 | 138001 | 138002 | 138003 | 139163

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.