Attachment 138002 Details for Bug 105429 – aes2501: Fix state machine never using "init_3" state

[patch] aes2501: Fix state machine never using "init_3" state

aes2501-Fix-state-machine-never-using-init3-state.patch (text/plain), 1.06 KB, created by Bastien Nocera on 2018-03-11 21:41:10 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Bastien Nocera

Created: 2018-03-11 21:41:10 UTC

Size: 1.06 KB

patch

obsolete

>From 444c312dd31e6a54f2a80f20d0ab4c547ec859cc Mon Sep 17 00:00:00 2001
>From: Bastien Nocera <hadess@hadess.net>
>Date: Sun, 11 Mar 2018 22:37:55 +0100
>Subject: [PATCH] aes2501: Fix state machine never using "init_3" state
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>This fixes this warning by the same token:
>drivers/aes2501.c:671:34: warning: âinit_3â defined but not used [-Wunused-const-variable=]
>
>https://bugs.freedesktop.org/show_bug.cgi?id=105429
>---
> libfprint/drivers/aes2501.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/libfprint/drivers/aes2501.c b/libfprint/drivers/aes2501.c
>index f6e3edf..c6ed20d 100644
>--- a/libfprint/drivers/aes2501.c
>+++ b/libfprint/drivers/aes2501.c
>@@ -784,7 +784,7 @@ static void activate_run_state(struct fpi_ssm *ssm)
> 		read_regs(dev, activate_read_regs_cb, ssm);
> 		break;
> 	case WRITE_INIT_3:
>-		aes_write_regv(dev, init_4, G_N_ELEMENTS(init_4),
>+		aes_write_regv(dev, init_3, G_N_ELEMENTS(init_3),
> 			activate_init3_cb, ssm);
> 		break;
> 	case WRITE_INIT_4:
>-- 
>2.14.3

Actions: View | Splinter Review

Attachments on bug 105429: 137970 | 137992 | 137993 | 137994 | 137995 | 137996 | 137997 | 137998 | 137999 | 138000 | 138001 | 138002 | 138003 | 139163

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.